Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#8100 closed defect (fixed)

“Privacy and Network Access Policy” window is needlessly confusing

Reported by: mpt Owned by: courmisch
Priority: normal Milestone: 2.1.0 release
Component: Interface: Qt Version: 2.0.5
Severity: minor Keywords:
Cc: Difficulty: unknown
Platform(s): Qt-supported (all) Work status: Not started


[This bug was originally reported on Launchpad.]

vlc 2.0.5-1, Ubuntu Ringtail

  1. Launch VLC for the first time (for example, in a guest session).

What happens: A "Privacy and Network Access Policy" window appears, containing this text from firstrun.cpp:

Privacy and Network Access Policy

VLC media player does not send or collect any information, even anonymously, about your usage.

However, it can connect to the Internet in order to display medias information .

VideoLAN (the authors) requires you to express your consent before allowing this software to access the Internet.

According to your choices, please check or uncheck the following options:

Network Access Policy

[/] Allow downloading media information

( Save and Continue )

What's wrong here:

  1. “VLC media player does not” is either incorrect grammar (“The VLC media player does not”) or, more likely, incorrect capitalization (“VLC Media Player does not”).
  1. Most of the window is in English, but “medias” is not, and “media” is used instead in the checkbox.
  1. There’s no explanation of what either “medias information” or “media information” is. This mystery prompted a posting on the VideoLAN forums, which explains that it’s cover art and track lists.
  1. There’s a stray space between "medias information" and the following period. This is because the text "or to check for available updates" is inserted into the sentence using an #ifdef UPDATE_CHECK with spaces misallocated between the strings. And using an #ifdef also makes the sentence difficult to translate.
  1. It isn’t clear whether “(the authors)” refers to the authors of VLC, the authors of the media, or the authors of the media information.
  1. “requires you express your consent” is the dialog talking about what the dialog is asking instead of just asking it.
  1. “According to your choices, please check or uncheck the following options” is filler text.
  1. Even if it wasn’t filler text, it refers to “options” when there is only one option, because the second is hidden by another #ifdef.
  1. The dialog contains two unnecessary group boxes, with the result that the string “Network Access Policy” appears three times in the window.
  1. “Save” is needlesly technical here.

I suggest replacing all this text with:

Welcome. How should VLC access the Internet when you're using it?

(*) Check for cover art, track lists, and software updates
( ) Check for cover art and track lists
( ) Check for software updates
( ) Don't access the Internet at all, thanks

( Exit ) ( Continue )

The first and third radio buttons can be omitted when UPDATE_CHECK is false.

Change History (5)

comment:1 Changed 3 years ago by fcartegnie

I don't remember the core differenciating internet accesses.

Where some text can be fixed, your UI design is worse.

  • You create 1 sentence per subset.
  • That doesn't even cover every combination.

Subsets elements are intended to be picked out by user. Example:

Allow access for:
[*]Cover arts
[*]Track Lists
[*]Sofwares Updates
  • (Exit) (Continue) ???

Why would the user Exit ? At least, for the current binary choice, that should be:

( Deny Internet Access ), ( Allow Internet Access )

comment:2 Changed 2 years ago by courmisch

We cannot "deny Internet access". The point of the dialog is to not access the Internet silently. VLC will always access the network if it is instructed to open a network-based media (HTTP, FTP...) or playlist service, regardless of the configuration.

Furthermore the use of checkboxes seems perfectly fine to me. It is far more logical a way to represent to separate yes/no choices (media infos, and software updates). It also leaves room for more options later.

comment:3 Changed 2 years ago by courmisch

  • Milestone changed from Bugs paradize to 2.1 bugs
  • Owner changed from jb to courmisch
  • Status changed from new to assigned

comment:4 Changed 2 years ago by courmisch

  • Platform(s) changed from all to Qt-supported (all)
  • Resolution set to fixed
  • Status changed from assigned to closed

comment:5 Changed 2 years ago by remi@…

commit 0faa838ce86232ca559b0459990fea4aa62957dd Author: Rémi Denis-Courmont <remi@…> Date: Sun Mar 24 14:28:47 2013 +0200

Qt4: clarify PNAP dialog (fixes #8100)

Also remove #ifdef from translated string since gettext can obviously not deal with that.

Note: See TracTickets for help on using tickets.