Regression: FLAC playback error

Madonna - MDNA Girls Gone Wild FLAC MDNA in FLAC format. On track 1 at 1 min 33secs it skips, I have tested with Nero Kwik Media, WMP and MPC and its does not skip with any of them.

Uploaded yesterday to http://streams.videolan.org/upload/

flac warning: the decoder was aborted by the read callback.
flac warning: an error in the stream caused the decoder to lose synchronization.
main warning: buffer way too early (-160078), clearing queue
main warning: timing screwed, stopping resampling
main debug: audio output is starving (-318161), playing silence

See #9442 (closed)

added Severity::normal Type::bug + 1 deleted label

changed milestone to %Bugs paradize

This is a regression since it's playing fine with VLC 1.1.11.

Changing the number of threads and/or the SRC algorithm has no effect.

And this does not occur with any other combination of player and decoder I've tried, including MPlayer and FFplay.

Both v2.0.1 release and v2.0.2 nightly build have the issue. v2.1 not tested.

Any updates on this issue?

assigned to @fenrir and unassigned @jbk

added Component::Demuxers label and removed 1 deleted label

Fenrir

Have you had any luck in resolving this issue?

http://streams.videolan.org/issues/7298/01%20Madonna%20-%20Girl%20Gone%20Wild.flac

http://streams.videolan.org/issues/6476/10__forteresse_error_2_49c.flac

See #6832 (closed)

changed title from FLAC playback error to Regression: FLAC playback error

assigned to @funman and unassigned @fenrir

--demux avformat OK

both --codec flac & --codec avcodec affected

changed the description

added Component::Packetizers label and removed Component::Demuxers label

At one point libavformat parser returns one big frame, while our packetizer returns 2.

The first frame is ok, the second one has 4 channels.

It is not clear (because the code is unreadable of course) why libavformat returns one big frame, or why returning one big frame makes the decoder happy.

If the flac decoder accepts concatenated frames we should look for a start marker until we reach the maximum frame size (p_sys->stream_info.max_framesize).

diff --git a/modules/packetizer/flac.c b/modules/packetizer/flac.c
index 090b601..4ed7a68 100644
--- a/modules/packetizer/flac.c
+++ b/modules/packetizer/flac.c
@@ -324,17 +324,20 @@ static block_t *Packetize( decoder_t *p_dec, block_t **pp_block )
                 if( p_header[0] == 0xFF && (p_header[1] & 0xFE) == 0xF8 )
                 {
                     /* Check if frame is valid and get frame info */
+                    int old_channels = p_sys->i_channels;
                     int i_frame_length =
                         SyncInfo( p_dec, p_header,
                                   &p_sys->i_channels,
                                   &p_sys->i_rate,
                                   &p_sys->i_bits_per_sample );
 
-                    if( i_frame_length )
+                    if( i_frame_length && old_channels == p_sys->i_channels)
                     {
                         p_sys->i_state = STATE_SEND_DATA;
                         break;
                     }
+                    else
+                        p_sys->i_channels = old_channels;
                 }
                 p_sys->i_frame_size++;
             }

commit 03e0644c Author: Rafaël Carré funman@videolan.org Date: Mon Oct 14 16:47:21 2013 +0200

flac packetizer: use the largest possible frame size

Fixes [#6476](https://code.videolan.org/videolan/vlc/-/issues/6476)
Fixes [#9442](https://code.videolan.org/videolan/vlc/-/issues/9442)

Original author: funman@videolan.org

added Status::fixed label

closed

changed milestone to %2.1.1