Crop video is broken for certain formats

When cropping to certain formats (mostly 5:4 and 1:1), the vout is correctly resized, but the video content is distorted.

This is reproducible using both the Mac OS X vout and the Direct3D one.

added Severity::major Type::bug + 1 deleted label

changed milestone to %Bugs paradize

assigned to @fkuehne and unassigned @jbk

added Component::Interface: macOS label and removed 1 deleted label

changed milestone to %2.0.1

Anyway to add myself to get ticket update notifications other than posting a comment like this one?

CC me.

@kdean: sure, just add yourself to the CC field (just done for this ticket)

Thanks. I cannot change the CC field as a normal user, at least I have not found any possibility to do that.

Yeah, same here. Normal users can't change anything in the top yellow box except when the new ticket is being created, but not after or on anyone elses ticket.

ah, sorry, I forgot that I got an admin account here...

Just to add an additional manifestation of this bug, trying to crop using option-i and option-k (crop one pixel off top/bottom) produces some odd flashing, but doesn't work. The image gets progressively wider, as VLC preserves the height and pixel aspect ratio (something else I wish it wouldn't do, but that's a separate ticket), but the black bars stay put.

This is the standard Intel 32-bit VLC 2.0.0 build, Compiled by fpk with llvm-gcc 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.6), on OS X 10.5.8.

Thanks for working to fix this!

Fixed in [6460f511].

added Status::fixed label

closed

commit 6460f511 Author: Felix Paul Kühne fkuehne@videolan.org Date: Mon Mar 5 20:43:35 2012 +0100

macosx: fixed aspect ratio and crop commands by removing a no longer needed hack (close [#5921](https://code.videolan.org/videolan/vlc/-/issues/5921), close [#6080](https://code.videolan.org/videolan/vlc/-/issues/6080))

Should this be fixed in latest nightly, because it's still broken for me.

Does not work for me, too.

And on your setups it goes right, felix? Strange... :-/

removed Status::fixed label

reopened