Visual feedback for audio volume changes

Hello,

In older versions of VLC, I found it quite helpful to get an optical feedback for the current audio volume. Especially when you are in full screen and use the shortcuts for increase / decrease volume, it was good to have the text message with the current volume level.

Unfortunately this feature was implicitly removed with the following commit for the mac os gui of vlc 1.2 and above: http://git.videolan.org/gitweb.cgi?p=vlc.git;a=commitdiff;h=0f3ee76af70c5e27ca9fe67238a59a3cc594cf93

I want to ask if this was intended and what you think about that.

It would be great if this feature could be readded for newer versions of vlc. AFAIK the behavior of the QT GUI is the same currently, so it could be considered if this could be (re)added for other guis too (perhaps with a change in the called functions).

The UI already has all the feedback necessary...

What do you mean by that? The ui does not feedback anything about audio currently.

In older versions of vlc, it seems that this feedback inside the video was done by some module which handles the video output.

Are you propose that every gui should overlay those information into the video view by itself now?

The UI widgets are moving...

... which are normally not visible when you are in fullscreen mode.

My point is: a lot of shortcuts produce this text feedback (e.g. delay, subtitle, changing audio track) besides the "normal" feedback in the corresponding panels or menus. Therefore this should be the same with the audio shortcuts.

If we want to be strictly conform with the rest implementation, we could distinguish between "hit the menu item" and "use the shortcut". But I think the additional feedback can also be tolerated when hitting the menu item because it contains more detailed information than the other audio widgets.

I agree. One needs to have visual feedback when changing the volume via keyboard or mouse while in fullscreen. I'd even advocate an option for showing an OSD while not in fullscreen as well. This is the way it's worked in the past.

changed milestone to %2.0.1

FIxed in [f70cd93d]

added Status::fixed label

closed

In previous versions of VLC, you sometimes saw a vertical volume level bar. With 2.0.1 we have the percentage which is fine, but just recently I noticed when I quickly adjust the volume with my keyboard I see the percentage change as expected, but occasionally I see a very brief flicker of the old volume level bar. So, either it's supposed to be there and it's not working 99% of the time, or it's an old remnant of code that needs to be removed.

Any comment on the audio level bar? And there's been some recent discussion in the forums about the old similar video progress bar when jumping that's no longer there but some people want. I didn't open a new bug since I didn't know if it was purposely left out.