Services Discovery Fails if loaded both by Preferences and Interfaces because playlist_IsServicesDiscoveryLoaded doesn't work in the way the interfaces expect it...

Per forum post at http://forum.videolan.org/viewtopic.php?f=13&t=86007 user jam123 determined if UPNP is enabled via the full preferences view by checking "Playlist->Services_Discovery->Universal_Plug'n'Play" (and restart to take effect) then UPNP service discovery fails on the playlist window you expand "Local_Network" and click on "Universal_Plug'n'Play" as it re-opens the module, open() called twice, which results in:

[0x9dbbb5c] upnp_intel services discovery error: UPNP_E_INIT [0x9dbbb5c] main services discovery error: no suitable services discovery module

If preference unchecked, which is the default, then no problem but should fix the double open.

Affects 1.1.7 and current git.

assigned to @jbk

Problem in Qt playlist model.

added Component::Interface: Qt label

1.1.7 is not expected to work anyway, with upnp on Windows.

About master:

The issue is that the name and longname are screwed up:

[0x8683084] main playlist debug: Name: video_dir{longname="My Videos"}, Longname: My Videos
[0x8683084] main playlist debug: Name: audio_dir{longname="My Music"}, Longname: My Music
[0x8683084] main playlist debug: Name: picture_dir{longname="My Pictures"}, Longname: My Pictures
[0x8683084] main playlist debug: Name: sap{longname="Network streams (SAP)"}, Longname: Network streams (SAP)
[0x8683084] main playlist debug: Name: xcb_apps{longname="Screen capture"}, Longname: Screen capture
[0x8683084] main playlist debug: Name: bonjour{longname="Bonjour services"}, Longname: Bonjour services
[0x8683084] main playlist debug: Name: v4l{longname="Video capture"}, Longname: Video capture
[0x8683084] main playlist debug: Name: alsa{longname="Audio capture"}, Longname: Audio capture
[0x8683084] main playlist debug: Name: disc{longname="Discs"}, Longname: Discs
[0x8683084] main playlist debug: Name: upnp{longname="Universal Plug'n'Play"}, Longname: Universal Plug'n'Play
[0x8683084] main playlist debug: Name: mtp{longname="MTP devices"}, Longname: MTP devices
[0x8683084] main playlist debug: Name: podcast{longname="Podcasts"}, Longname: Podcasts
[0x8683084] main playlist debug: Name: lua{sd='fmc',longname='Free Music Charts'}, Longname: Free Music Charts
[0x8683084] main playlist debug: Name: lua{sd='freebox',longname='Freebox TV'}, Longname: Freebox TV
[0x8683084] main playlist debug: Name: lua{sd='icecast',longname='Icecast Directory'}, Longname: Icecast Directory
[0x8683084] main playlist debug: Name: lua{sd='jamendo',longname='Jamendo Selections'}, Longname: Jamendo Selections
[0x8683084] main playlist debug: Name: lua{sd='metachannels',longname='Channels.com'}, Longname: Channels.com
[0x8683084] main playlist debug: Name: lua{sd='appletrailers',longname='Apple Trailers'}, Longname: Apple Trailers
[0x8683084] main playlist debug: Name: lua{sd='fmc',longname='Free Music Charts'}, Longname: Free Music Charts
[0x8683084] main playlist debug: Name: lua{sd='freebox',longname='Freebox TV'}, Longname: Freebox TV
[0x8683084] main playlist debug: Name: lua{sd='frenchtv',longname='French TV'}, Longname: French TV
[0x8683084] main playlist debug: Name: lua{sd='icecast',longname='Icecast Directory'}, Longname: Icecast Directory
[0x8683084] main playlist debug: Name: lua{sd='jamendo',longname='Jamendo Selections'}, Longname: Jamendo Selections
[0x8683084] main playlist debug: Name: lua{sd='katsomo',longname='Katsomo.fi'}, Longname: Katsomo.fi
[0x8683084] main playlist debug: Name: lua{sd='librivox',longname='librivox'}, Longname: librivox
[0x8683084] main playlist debug: Name: lua{sd='magnatune',longname='Magnatune'}, Longname: Magnatune
[0x8683084] main playlist debug: Name: lua{sd='metachannels',longname='Channels.com'}, Longname: Channels.com
[0x8683084] main playlist debug: Name: lua{sd='sd_metachannels',longname='Meta channels'}, Longname: Meta channels
[0x8683084] main playlist debug: Name: lua{sd='shoutcast_radio',longname='Shoutcast Radio'}, Longname: Shoutcast Radio

when adding:

msg_Dbg( obj, "Name: %s, Longname: %s", names[i], longnames[i] ); in the loop in vlc_sd_GetNames, line 85 in src/playlist/services_discovery.c

Then, when Qt interface (and Mac) tries to do:

playlist_IsServicesDiscoveryLoaded( THEPL, "upnp{longname="Universal Plug'n'Play"}" ); it always returns false.

Therefore, I believe the issue is in the object names modification, especially for SD.

added Component::Core label and removed Component::Interface: Qt label

changed milestone to %2.0.0 bugs

unassigned @jbk

changed title from UPNP Services Discovery Fails If Enabled Via Preferences to Services Discovery Fails if loaded both by Preferences and Interfaces because playlist_IsServicesDiscoveryLoaded doesn't work in the way the interfaces expect it...

assigned to @Courmisch

This bug was partly worked around with [13fb436d]. I think it is fundamentally unfixable without changing the internal SD object API. That would be way overkill.

added Status::will not fix label

closed