Opened 10 years ago

Closed 10 years ago

#412 closed defect (fixed)

ffmpeg /other module(s) missing

Reported by: md Owned by:
Priority: high Milestone:
Component: Build system Version: master git
Severity: major Keywords:
Cc: Difficulty: unknown
Platform(s): all Work status: Not started

Description

There are two problems in the build system:

  • since [12884] ffmpeg is not detected, if present on the default place or --with-ffmpeg-tree is given.
  • there is some weird whitespace problem, if the vlc-config reads: plugins=" plugin1 plugin2 plugin3" the last plugin is not complilled on FreeBSD. However, if I change it to plugins=" plugin1 plugin2 plugin3 " everything is fine. The same applies for builtins.

Change History (4)

comment:1 Changed 10 years ago by hartman

Can you please put your vlc-config and config.log online?

comment:2 Changed 10 years ago by md

I've posted the files at http://md.bts.sk/vlc There are 3 files:

  • configure as created by bootstrap
  • configure.diff to better see what's missing in configure. The configure.good was created by removing the new lines 2170 - 2183 and 2285 added in [12884]
  • vlc-config after my modification (added whitespace at the end of "plugins" and "builtins" definitions at the top) - this one works, without the extra whitespaces at the end the last module/builtin is not compilled on FreeBSD.

comment:3 Changed 10 years ago by md

The first problem is in the bootstrap:

if [ "${PKGCONFIG}" = "no" ]; then cat >> m4/private.m4 << EOF
dnl  User does not have pkg-config, so this is a no-op
AC_DEFUN([PKG_CHECK_MODULES], [:], [], [], [])

If pkg-config is not present, it shouldn't perform a no-op, but instead include the code specified by last argument (as if package was not found).

The second problem could be resolved by adding an extra whitespace to both PLUGINS and BUILTINS just before vlc-config is written.

comment:4 Changed 10 years ago by md

  • Resolution set to fixed
  • Status changed from new to closed

(In [13095]) fix for missing modules - hope this closes #412

Note: See TracTickets for help on using tickets.