Opened 5 years ago

Closed 5 years ago

#3928 closed defect (fixed)

XVideo output: green lines

Reported by: courmisch Owned by:
Priority: normal Milestone: 1.1.3
Component: Core: Video output Version: master git
Severity: normal Keywords:
Cc: Difficulty: unknown
Platform(s): Linux Work status: Not started

Change History (6)

comment:1 Changed 5 years ago by courmisch

  • Status changed from new to assigned

comment:2 Changed 5 years ago by courmisch

  • Owner courmisch deleted
  • Status changed from assigned to new

This affects both SHM and non-SHM cases, and seems like a regression in VLC 1.1.0.

I can't find anything wrong in the VLC XV plugin though.

comment:3 Changed 5 years ago by heaven

VLC 1.1.0 had the same problem. Even on a files that mplayer plays without these green line and through the same XVideo output.

comment:4 Changed 5 years ago by fenrir

This patches workaround it for me but it degrades performances on non mod16 video as direct rendering will be disabled (ie the video pictures will be copied).

diff --git a/modules/video_output/xcb/xvideo.c b/modules/video_output/xcb/xvideo.c
index 8b8190c..90097db 100644
--- a/modules/video_output/xcb/xvideo.c
+++ b/modules/video_output/xcb/xvideo.c
@@ -252,8 +252,8 @@ FindFormat (vout_display_t *vd,
         /* VLC pads scanline to 16 pixels internally */
-        unsigned width = (fmt->i_width + 15) & ~15;
-        unsigned height = (fmt->i_height + 15) & ~15;
+        unsigned width = fmt->i_width;
+        unsigned height = fmt->i_height;
         xcb_xv_query_image_attributes_reply_t *i;
         i = xcb_xv_query_image_attributes_reply (conn,
             xcb_xv_query_image_attributes (conn, port, f->id,

comment:5 Changed 5 years ago by fenrir

It degrades performances only when direct rendering can effectively be used, for example with mpeg2/mpeg4-asp/... Which is not the case with this sample file as it uses H264, and avcodec wants extra padding lines for h264 (and xcb xv doesn't provides them).

comment:6 Changed 5 years ago by courmisch

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.