Win32 Installer: It should NOT delete files that it doesn't create

Example:

1. Create this file => C:\Program Files\VideoLAN\VLC\lua\extensions\test.lua
2. Install VLC 1.1
3. Uninstall it

You can see that the file test.lua is deleted, and it is very bad. Tested on vlc-1.1.0-git-20100311-0002-win32.exe

Indeed. I believe geal's changes are at fault.

assigned to @geal

added Severity::major label

No, these are not my fault. Read the code before saying bullshit.

Anyway, it's an easy fix.

added Difficulty::easy label

ok, sorry.

Thanks for taking care about this lua mess..

This bug is tricky, and you need to follow thes steps to reproduce it: *install VLC *put test.lua in lua/extensions *Uninstall. Now, you will see that the file is still there *Reinstall. Now, you will see that test.lua appears in uninstall.log, because the file is found by the macro "InstallFolder lua" *Uninstall. Now, the file disappears

So, the installer should look for files already present, and remove them from uninstall.log

The uninstaller deleting the AppData/Roaming/vlc folder is much more annoying that the uninstaller deleting a file in a place where the user shouldn't mess.

The behaviour is wrong at the basis, the installer should store the list of files (that should be deleted at uninstall) at compile time and not at install time, also for file added with wildcard.

changed milestone to %1.1.0-release

changed title from Installer: It should NOT delete files that it doesn't create to Win32 Installer: It should NOT delete files that it doesn't create

http://nsis.sourceforge.net/Uninstall_only_installed_files

changed milestone to %1.1.x maintenance

changed milestone to %2.1.x maintenance bugs

unassigned @geal

The current installer in the GIT repo is capable of doing so, if I see that correctly. Can't test currently, as I'm missing a libary for Win64 detection.

Original author: https://www.google.com/accounts/o8/id?id=aitoawkxo5j5h_mux3ecdrrzrr9w_j3p_wwolvs

It does not behave correctly, hence the bug.

Ah, okay, should have red comment number 4. Workin on it again

Original author: https://www.google.com/accounts/o8/id?id=aitoawkxo5j5h_mux3ecdrrzrr9w_j3p_wwolvs

Added attachment:

• fileremoval_fix.patch

Original author: https://www.google.com/accounts/o8/id?id=aitoawkxo5j5h_mux3ecdrrzrr9w_j3p_wwolvs

added Component::Win32 Installer label

added Type::patch label