FLAC playback terminates before playing all audio (final <250ms clipped) (all platforms Linux, Android, Windows)

Hello, As described here (https://forum.videolan.org/viewtopic.php?f=2&t=155066) I have a bug where FLAC codec play back stops ~250ms before it should on every song I try on every platform I try. Here is a modified copy-paste of that thread:

Bug Description The final ~250ms of FLAC tracks are skipped during audio playback on Arch Linux x64 VLC 3.0.11.1-3, on Android using VLC 3.2.12 from Google Play (model: SGS7E), and on Windows 10 x64 (HP G3 Laptop).

For those who would like an example, the popular album "To Pimp A Butterfly" makes heavy use of hard cuts at the end of tracks during spoken dialogue and it is very apparent on track 05, "These Walls". Kendrick does not finish saying the phrase "in a Hotel Room" in FLAC. He instead says "in a Hote". The sounds for [Hote]"l room" are clipped entirely.

This is 100% reproducible per listen and happens on any track I have tried -- however... that being said it's quite difficult to notice if you don't have a good track candidate to show off the problem (many tracks have silence here).

Steps to Demonstrate Bug

• Find a song with important information in the last 200ms of the song
• Rip it using (e.g.) Rhythmbox, default FLAC settings -- nothing fancy
• Play it as FLAC
• Expected: you hear this part of the song
• Actual: You do not hear this part of the song
• Workaround: Use $ flac -d to decode it to WAV. The track now terminates playback completely.

Irrelevant Factors

• Audio output device (using reliable hardware or aux out speakers that work with other players, it fails. On Android hardware speaker, wired headphones, bluetooth all fail)
• Platform (Linux, Android, Windows all share this defect)
• Audio import tool (used Rhythmbox, Sound Juicer, cdparanoia through abcde -o flac)
• Playlist order or count (having more tracks before or after is irrelevant. playing alone is irrelevant)
• File source (local fails the same as network play, internal disk vs. USB irrelevant)

Didn't Try

• Lossy codecs. Wav works, FLAC doesn't. That was enough for me.

Nearby Topics

• https://forum.videolan.org/viewtopic.ph ... ty#p499193 looks like a similar playback issue but older versions and different formats. WAV works for me
• https://forum.videolan.org/viewtopic.ph ... ck#p500852 mine occurs at the end not the beginning of tracks
• https://forum.videolan.org/viewtopic.ph ... ap#p472672 potentially related?

This rabbit hole went way deeper than I thought -- I thought it was an Android-only bug.

End Copy Paste

I have prepared a file in VLC that shows off this defect quite nicely. I'm going to upload it after submitting this ticket.

I'm quite new to VLC's codebase but I'll take a look in myself and am open to pointers and running test builds. Next up here is to try building my own copy and running that so I can work on this, too.

added Component::Core: Audio output Severity::normal Type::bug Version::3.0.x + 1 deleted label

changed milestone to %Bugs paradize

sample to show thte defect. The final (third) click is not heard in VLC

Added attachment:

• 2020-10-06 vlc-bug-track.flac

Original author: Bujiraso

Attachment added. I will also note here that this also affects video playback indirectly.

If the audio track is FLAC the scene will terminate early just the same. Not a terribly huge surprise, but quite noteworthy anyway.

Original author: Bujiraso

It also seems like #17684 (closed) is better but not working in the latest Arch Linux 3.0.11.1-3 version as scrubbing around in that file I uploaded (e.g. to skip to the 15s mark) is still broken for me.

I was the one who filed this way back then. I can re-open it, of course, but I'd rather ask for a second opinion before doing so.

Original author: Bujiraso

Hi,

Thank you for the very detailed bug report.

I can reproduce on VLC 3, but it works on current master branch (VLC 4 in development).

Regards

Confirmed. Works good on VLC 4 on Windows x64 nightly (20201017, 6416ea54) Scrubbing works good too.

Network shares don't seem to work so I can't test FLAC on Video to confirm that is fixed, too.

Is there a way of backporting this fix to 3.X or is it too big a change? Additionally, I'd be interested to know when a 4.0 build would be estimated to arrive on Android (even beta) as that is my primary listening device and this bug is something I'd like to have fixed.

Original author: Bujiraso

changed milestone to %4.0

closed

unassigned @MigrationBot

mentioned in issue vlc-android#2848

added Status::fixed label