D3DX: Wrong aspect ratio with some files with hw decoding

I have some MP4 files with 720x576 pixel format (4:3) and a SAR value of 64:45 (16:9)

Since vlc-3.0.0-20170810-0509-git, VLC shows the video in 4:3 instead of 16:9

https://streams.videolan.org/issues/19435/

Logs of last build without the problem

Added attachment:

• vlc-3.0.0-20170809-0456-git-win64.log

Logs of first build with the problem

Added attachment:

• vlc-3.0.0-20170810-0509-git-win64.log

Sample was uploaded by VideoLAN file Uploader

Regression

changed the description

changed milestone to %3.0.0

assigned to @fcartegnie

not related to MP4 at all. works fine here

added 1 deleted label

changed title from Wrong aspect ratio with some MP4 files to Wrong aspect ratio with some files

see vout / decoder

likely d3d9 to d3d11 change

possible. Steve?

Tested on https://nightlies.videolan.org/build/win64/vlc-3.0.0-rc6-20180115-0505/

With either d3d9 or d3d11 output:

• with hw acceleration enabled: the video is displayed in 4:3
• with hw acceleration disabled: the video is displayed in 16:9

changed title from Wrong aspect ratio with some files to D3DX: Wrong aspect ratio with some files with hw decoding

added Component::Video: Direct3D / Win32 label and removed 1 deleted label

assigned to @robUx4 and unassigned @fcartegnie

I can confirm the switch of behaviour in the nightly builds. But when building an older that should work I still see the issue. I wonder if that's something in the contribs.

Even after rebuilding and old ffmpeg, a build from August 4th 2017 still has the issue. So I'm not exactly what changed to make it not work anymore (or maybe that's really how the file should be displayed).

MediaInfo reports an aspect ratio of 16:9 though, and a pixel size of 720x576.