Return to normal size after fullscreen

if you select to start video in fullscreen, VLC will also resize main interface to that size after end of playback.

---

||=ver=||=win=|| ||3.0 x64 ||10

Seen on my Solaris builds as well, so not confined to Windows.

assigned to @ssbssa

added 1 deleted label

It looks like this behavior was introduced with 610ecb908b6855f836840f4b80aa7c30f5499374, in particular the setVideoFullScreen() before showVideo().

In showTab() (inside showVideo()), the size is saved inside stackWidgetsSizes[], but since it changed into fullscreen earlier, that's the size that is used after the video stops.

For me (on windows) that was enough to fix it:

diff --git a/modules/gui/qt/main_interface.cpp b/modules/gui/qt/main_interface.cpp
index 2da22fd..1806b89 100644
--- a/modules/gui/qt/main_interface.cpp
+++ b/modules/gui/qt/main_interface.cpp
@@ -733,11 +733,11 @@ void MainInterface::getVideoSlot( WId *p_id, struct vout_window_t *p_wnd,
     *p_id = ret;
     if( ret ) /* The videoWidget is available */
     {
-        setVideoFullScreen( fullscreen );
-
         /* Consider the video active now */
         showVideo();
 
+        setVideoFullScreen( fullscreen );
+
         /* Ask videoWidget to resize correctly, if we are in normal mode */
         if( !isFullScreen() && !isMaximized() && b_autoresize )
             videoWidget->setSize( *pi_width, *pi_height );

Please comment.

Your patch did not work on X11. The problem is that setMinimalView wants to call resize(), which may occur before or after the window is done entering/exiting fullscreen.

I have a patch that fixes the problem for me, can you confirm it works on windows?

https://patches.videolan.org/patch/12740/

Seems fixed now in 3.0

added Status::fixed label

changed milestone to %3.0 FF

closed

Milestone renamed