WebVTT subtitle not working properly (at least on Windows)

It seems that a valid .vtt (WebVTT) subtitle file is not displayed at all if it contains timestamps in the format mm:ss.ddd i.e. without the two (or more) ASCII digits representing the "hours" when "hours" is zero.

Given that WebVTT timestamp format mm:ss.ddd (instead of hh:mm:ss.ddd) is a valid a very common format when "hours" is zero, WebVTT subtitle file are quite almost unusable.

System: Windows 7 Home Premium 64 bit VLC: 2.2.1 32 bit

Works for me in 3.0.0

Please try a nightly build.

added Status::fixed + 1 deleted label

changed milestone to %3.0.0

closed

WebVTT test file

Added attachment:

• test.vtt

I tried the nightly build vlc-2.2.0-20151204-0204\vlc-2.2.2-win32.exe but it has the same problem.

I also tried vlc-3.0.0-20151204-0004\vlc-3.0.0-git-20151204-0004-win32.exe but it doesn't work at all so I cannot test it.

Moreover I didn't find substantial difference between 2.2.1 version and master version of modules/demux/subtitle.c.

Could you please check the attached test file? Could you please specify where and when the patch was introduced in the source code?

removed Status::fixed label

reopened

assigned to @fcartegnie

It seems the bug is in the following lines:

https://github.com/videolan/vlc/blob/master/modules/demux/subtitle.c#L2193-L2204

            ( sscanf( s,"%d:%d:%d.%d --> %d:%d:%d.%d",
                        &h1, &m1, &s1, &d1,
                        &h2, &m2, &s2, &d2 ) == 8 ||
                sscanf( s,"%d:%d:%d.%d --> %d:%d.%d",
                        &h1, &m1, &s1, &d1,
                             &m2, &s2, &d2 ) == 7 ||
                sscanf( s,"%d:%d.%d --> %d:%d:%d.%d",
                             &m1, &s1, &d1,
                        &h2, &m2, &s2, &d2 ) == 7 ||
                sscanf( s,"%d:%d.%d --> %d:%d.%d",
                             &m1, &s1, &d1,
                             &m2, &s2, &d2 ) == 6 );

that need to be rewritten as:

            ( sscanf( s,"%d:%d.%d --> %d:%d.%d",
                             &m1, &s1, &d1,
                             &m2, &s2, &d2 ) == 6 ||
               sscanf( s,"%d:%d.%d --> %d:%d:%d.%d",
                             &m1, &s1, &d1,
                        &h2, &m2, &s2, &d2 ) == 7 ||
               sscanf( s,"%d:%d:%d.%d --> %d:%d.%d",
                        &h1, &m1, &s1, &d1,
                             &m2, &s2, &d2 ) == 7 ||
               sscanf( s,"%d:%d:%d.%d --> %d:%d:%d.%d",
                        &h1, &m1, &s1, &d1,
                        &h2, &m2, &s2, &d2 ) == 8 );

dubious. more likely hours set from previous probing.

fcartegnie, you are right, so probing first with %d:%d.%d instead of %d:%d:%d.%d solves the problem. I tested it against the 4 possible cases.

Milestone renamed

changed milestone to %3.0 FF

added Status::fixed label

closed

Milestone renamed