Change of font while displaying subtitles

When the Unicode character 'THIN SPACE' (code point 0x2009) is found in subtitles and the current font is Serif then all the text after the thin space is in Sans Serif.

Example of change of font on the same line

Added attachment:

• screenshot_vlc_subs_resized.png

Please share VLC version and a sample.

Replying to [comment:1 jb]:

Please share VLC version and a sample.

OK. VLC version is the one of the master branch on git, i.e.

$ vlc --version
VLC media player 3.0.0-git Vetinari (revision 2.2.0-git-5235-g9462621)
VLC version 3.0.0-git Vetinari (2.2.0-git-5235-g9462621)
Traductions © 2008-2013 Éric Lassauge
Compilé par rbazaud sur box.localdomain (Nov  8 2015 23:28:56)
Traduction : Éric Lassauge - Team français traduction VLC
Compilateur : gcc version 5.2.1 20151028 (Debian 5.2.1-23)
Ce programme est fourni SANS AUCUNE GARANTIE, tel que permis par la loi.
Vous pouvez le redistribuer selon les termes de la Licence Publique Générale GNU;
voir le fichier COPYING pour plus de détails.
Écrit par l'équipe VideoLAN; voir le fichier AUTHORS.

as for the sample, it is coming…

Tested ok i.e. bug reproduced

Added attachment:

• sample_pb_vlc.srt

I cannot reproduce.

I see a square in the middle, but I don't have the change of font family, just a change of font size.

If you see a square that means that the typeface (or font) you’re currently using to display subtitles doesn’t define a glyph corresponding to this code point i.e. 0x2009, in which case it defaults to the glyph «.notdef» (sometimes a square, sometimes a square with a cross inside, … ) as a fallback. I’m currently using the font TeX Gyre Schola (http://www.gust.org.pl/projects/e-foundry/tex-gyre/), which is a free replacement for the Century Schoolbook typeface (originally designed by Morris Fuller Benton, 1919, for the American Type Founders). Anyway if you got a change of font on the same line, it might be related to the same issue. There exist many kinds of white spaces in Unicode standard, cf. https://en.wikipedia.org/wiki/Whitespace_character but I haven't tested them all.

Added attachment:

• 0001-freetype-handle-special-space-characters-close-15840.patch

Hello,

I'm attaching a patch to address the problem.

Does this patch fix the issue for you?

Replying to [comment:5 sal-sh]:

Hello,

I'm attaching a patch to address the problem.

Does this patch fix the issue for you?

Problem solved. Great job !

Applied! \o/

Great job, Salah!

Replying to [comment:6 rbazaud]:

Replying to [comment:5 sal-sh]:

Hello,

I'm attaching a patch to address the problem.

Does this patch fix the issue for you?

Problem solved. Great job !

Thanks for reporting :)

Replying to [comment:7 jb]:

Applied! \o/

Great job, Salah!

Thanks :)

added Status::fixed label

changed milestone to %3.0.0

closed

Milestone renamed

changed milestone to %3.0 FF

Milestone renamed