RC interface with --rc-fake-tty using stdin/stdout does not work on VLC 0.8.6[def]

A change to modules/control/rc.c in 0.8.6d (http://git.videolan.or/gitweb.cgi/vlc.git/?a=commit;h=c37341f13f0d0a7ef847a9caf1688d01882627ce) breaks the RC interface (input ignored, no output) when trying to control VLC from another program (stdin/stdout and --rc-fake-tty) on Linux (possibly also other unix variants). This change appears to be absent from 0.9.0 (as seen from https://trac.videolan.org/vlc/browser). For reference, the bug report to Gentoo: http://bugs.gentoo.org/show_bug.cgi?id=219318

The change looks correct to me.

Why are using --rc-fake-tty ?

assigned to @funman

added Difficulty::easy label

changed milestone to %0.8.6 maintenance

Why are you using --rc-fake-tty ?

No it was not correct ^^ fixed in [232337c3a3aba420a779aeb61b1dfbff267b6e6f]

added Status::fixed label

closed

The fix looks OK to me, have to test it to make sure.

To answer your question, the RC interface will not work without --rc-fake-tty if stdin/stdout is not a TTY, such as when controlling VLC from another program (in my case my own media center UI).

Well, your media center UI is kinda broken then. It should control VLC through a PTS/PTY pair anyway, so you don't need the fake-tty hack.

Replying to [comment:5 courmisch]:

Well, your media center UI is kinda broken then. It should control VLC through a PTS/PTY pair anyway, so you don't need the fake-tty hack.

Why? The RC interface does not need any TTY properties from stdin/stdout (as it works with --rc-fake-tty and the only place it uses that variable is in the isatty(0) check), so why should the control channel be a TTY instead of the much simpler (and more common) pipe?