S_DVBSUB detection fails in .mkv

[Felix Paul Kühne]

DVBSUBs are correctly detected and displayed when muxed to MPEG TS but fail with MKV.

This supported in Kodi and mplayer.

[Felix Paul Kühne]

Sample file here: ​http://streams.videolan.org/issues/14577/

[Jean-Baptiste Kempf]

diff --git a/modules/demux/mkv/matroska_segment_parse.cpp b/modules/demux/mkv/matroska_segment_parse.cpp
index bfb64a5..90439cf 100644
--- a/modules/demux/mkv/matroska_segment_parse.cpp
+++ b/modules/demux/mkv/matroska_segment_parse.cpp
@@ -1828,6 +1828,10 @@ int32_t matroska_segment_c::TrackInit( mkv_track_t * p_tk )
     {
         p_tk->fmt.i_codec = VLC_CODEC_BD_PG;
     }
+    else if( !strcmp( p_tk->psz_codec, "S_DVBSUB" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_DVBS;
+    }
     else if( !strcmp( p_tk->psz_codec, "B_VOBBTN" ) )
     {
         p_tk->fmt.i_cat = NAV_ES;

[Jean-Baptiste Kempf]

See ​https://github.com/mbunkus/mkvtoolnix/issues/1648#issuecomment-204782691

[perex]

@jb - So what prevents to push this two line fix to the main source tree ?

[Jean-Baptiste Kempf]

An official spec, I guess

[perex]

It's in the official specs: ​https://github.com/Matroska-Org/matroska-specification/blob/master/codec_specs.md and ​https://github.com/Matroska-Org/matroska-specification/blob/master/subtitles.md !!!

[perex]

ping

[Steve Lhomme]

Simply mapping the codec ID is not enough. We need to map the codec private data internally to something that looks more like a DVB frame to the decoder.

[trujulu]

Any updates here?

[Jean-Baptiste Kempf]

No.

[Steve Lhomme]

Fixed by ​{4d22be6dcc60eed789a278b1105a01f59168f8cb}