DxVA broken in 2.2.0

Tested on the Surface Pro 1, Windows 64bits.

Fails using libav from 2.2.0, same for FFmpeg

http://streams.videolan.org/streams/matroska/%5bFubuki%5d_11eyes_-01%5b1280x720%5d%5b384630F3%5d.mkv

VLC 2.1.3 and 2.1.5 work.

added Component::Decoders Severity::normal Type::bug Version::master git + 1 deleted label

changed milestone to %Bugs paradize

assigned to @flx42 and unassigned @MigrationBot

changed milestone to %2.2.0

changed the description

see also #11693 (closed)

Using the libavcodec libraries from 2.1.5 does the same. So, the issue is in our code.

#11693 (closed) does not help much.

Especially since the issue is not the same as 2.1.3

It seems settings threads to 1 fixes this.

I've ran a regression using the win32 nightlies, the bug appeared between 15-07-2013 and 22-07-2013. Commit 9b28b4c6 is probably the one who exposed the bug.

With the current code, if we disable frame threading (and use slice threading instead) then glitching is gone. But this is probably the same as setting the number of threads to 1 since most videos have only one slice.

Then, let's revert the code for Win32 only with hw acceleration.

commit bf9b9955 Author: Felix Abecassis felix.abecassis@gmail.com Date: Mon Aug 25 12:07:22 2014 +0200

avcodec: disable frame multithreading with dxva2

Fix [#11930](https://code.videolan.org/videolan/vlc/-/issues/11930), [#11693](https://code.videolan.org/videolan/vlc/-/issues/11693)

Original author: felix.abecassis@gmail.com

added Status::fixed label

closed

VLC developers have experienced the problem, I talked about it at the VLC dev conference. [https://trac.ffmpeg.org/ticket/604 #604 (closed)]

mentioned in issue #12021 (closed)