chapters in ogg not shown if the key is uppercase

Hi,

In an ogg or opus container, the chapters are vorbis comments of type key=value. If a chapter key is uppercase (CHAPTER001, CHAPTER001NAME, CHAPTER001URL), the chapters are not shown in the GUI. If the key is lowercase (chapter001…), it works.

I tested with an ogg or opus container, with a theora, opus or vorbis stream, on FreeBSD 9.2 with VLC 2.1.1

Solution? lowercase after parsing and before using, probably.

I can give you more information if needed…

Thanks

I really doubt it, since the code uses UPPERCASE for parsing...

sscanf( psz_comment, "CHAPTER%uNAME=", &i_chapt )

Using lowercase here is complete brain damage.

assigned to @fcartegnie

There's an UPPERCASE conversion if LOWERCASE is detected, and CHAPTER* tag is detected using strncasecmp()

Thanks for replying !

And sorry, I was wrong for the solution I proposed. I rebuilt VLC (just in case), but the problem is still there.

I created the problematic files with ffmpeg, with the 2 following commands :

ffmpeg -threads auto -y -i in.ogg -i metadata_OGG.txt -map_metadata 1 -codec copy out_METADATA.ogg
ffmpeg -threads auto -y -i in.ogg -i metadata_ogg.txt -map_metadata 1 -codec copy out_metadata.ogg

where the 2 metadata files are as follows : metadata_OGG.txt :

;FFMETADATA1
TITLE=Le meilleur de l'Afreubo
DATE=2000
ARTIST=Afreubo
ALBUM=Le meilleur de l'Afreubo
GENRE=Philharmonique
CHAPTER001=00:00:00.000
CHAPTER001NAME=track 01 - Y.M.C.A.
CHAPTER002=00:02:24.627
CHAPTER002NAME=track 02 - Mission impossible
…

and metadata_ogg.txt

;FFMETADATA1
title=Le meilleur de l'Afreubo
date=2000
artist=Afreubo
album=Le meilleur de l'Afreubo
genre=Philharmonique
chapter001=00:00:00.000
chapter001name=track 01 - Y.M.C.A.
chapter002=00:02:24.627
chapter002name=track 02 - Mission impossible
…

FFmpeg recognize the chapters in each case :

ffmpeg -threads auto -y -i out_METADATA.ogg
ffmpeg version 2.1.1 Copyright (c) 2000-2013 the FFmpeg developers
  built on Nov 21 2013 16:52:18 with gcc 4.2.1 (GCC) 20070831 patched [FeeBSD]
  configuration: --disable-libaacplus --disable-indev=alsa --disable-outdev=alsa --disable-libopencore-amrnb --disable-libopencore-amrwb --disable-libass --enable-libcdio --disable-libcelt --enable-libfaac --disable-libfdk-aac --enable-ffserver --enable-fontconfig --enable-libfreetype --enable-frei0r --enable-gnutls --disable-libgsm --enable-iconv --disable-indev=jack --enable-libmp3lame --disable-libbluray --enable-libv4l2 --disable-libmodplug --disable-openal --disable-indev=openal --enable-libopencv --disable-libopenjpeg --enable-libopus --disable-libpulse --disable-indev=pulse --disable-outdev=pulse --disable-librtmp --enable-libschroedinger --disable-libspeex --enable-libtheora --enable-vaapi --enable-vdpau --enable-libvorbis --disable-libvo-aacenc --disable-libvo-amrwbenc --enable-libvpx --enable-libx264 --enable-libxvid --prefix=/usr/local --mandir=/usr/local/man --datadir=/usr/local/share/ffmpeg --enable-shared --enable-gpl --enable-postproc --enable-avfilter --enable-avresample --enable-pthreads --enable-memalign-hack --disable-libstagefright-h264 --disable-libutvideo --disable-libsoxr --cc=cc --extra-cflags='-I/usr/local/include/vorbis -I/usr/local/include' --extra-ldflags='-L/usr/local/lib ' --extra-libs=-pthread --disable-debug --disable-sse --disable-mmx --enable-nonfree
  libavutil      52. 48.101 / 52. 48.101
  libavcodec     55. 39.101 / 55. 39.101
  libavformat    55. 19.104 / 55. 19.104
  libavdevice    55.  5.100 / 55.  5.100
  libavfilter     3. 90.100 /  3. 90.100
  libavresample   1.  1.  0 /  1.  1.  0
  libswscale      2.  5.101 /  2.  5.101
  libswresample   0. 17.104 /  0. 17.104
  libpostproc    52.  3.100 / 52.  3.100
Input [#0](https://code.videolan.org/videolan/vlc/-/issues/0), ogg, from 'out_METADATA.ogg':
  Duration: 00:14:59.56, start: 0.000000, bitrate: 127 kb/s
    Chapter [#0](https://code.videolan.org/videolan/vlc/-/issues/0).0: start 0.000000, end 144.627000
    Metadata:
      title           : track 01 - Y.M.C.A.
    Chapter [#0](https://code.videolan.org/videolan/vlc/-/issues/0).1: start 144.627000, end 899.560000
    Metadata:
      title           : track 02 - Mission impossible
    …
    …
    Stream [#0](https://code.videolan.org/videolan/vlc/-/issues/0):0: Video: theora, yuv420p, 110x110 [SAR 1:1 DAR 1:1], 25 tbr, 25 tbn, 25 tbc
    Metadata:
      ENCODER         : Lavf55.19.104
      TITLE           : Le meilleur de l'Afreubo
      DATE            : 2000
      ARTIST          : Afreubo
      ALBUM           : Le meilleur de l'Afreubo
      GENRE           : Philharmonique
At least one output file must be specified

But in the VLC GUI, in Play > Chapters, there is nothing for one file (uppercase key in metadata), and the expected chapters for the other (lowercase key in metadata).

Did you reproduce it ?

Already fixed in master.

added Status::works for me label

closed

Ok, thanks for your time !