Ticket #869 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

playlist-enqueue functionality

Reported by: jmlane Assigned to: courmisch
Priority: normal Milestone: 0.9.0-test1
Component: Playlist Version: master
Severity: normal Keywords:
Cc: md, dionoea, hartman, sambrightman Platform(s): Win32
Difficulty: unknown Work status: Not started

Description

Using Windows XP Pro testing 0.8.6-test2a-30061128-0331 W32 nightly build.

Both shell context items "Add to VLC media player's Playlist" (vlc.exe --started-from-file --playlist-enqueue "%1") and "Play with VLC media player" cause the same action in VLC: VLC enqueues selected item in the playlist AND starts playing the first new playlist item enqueued.

Proper functionality would probably have --no-playlist-enqueue either replace the playlist with selected items OR --playlist-enqueue would simply append the items to the playlist and not start playback.

Change History

12/05/06 20:55:42 changed by hartman

  • cc set to md, dionoea.

the problem is the following i guess. VLC launches with one instance AND enqueue. This version of VLC then finds a "master vlc", and thinks: "we should add this file to that master vlc". The master VLC thread gets the information, but does not parse the "playlist-enqueue" config variable. Therefore in src/misc/win32_specific.c +347, config_GetInt( "playlist-enqueue" ), retrieves the value of the MASTER vlc, and not of the "feeding" vlc.

12/06/06 08:49:54 changed by md

  • cc changed from md, dionoea to md, dionoea, hartman.

Yes, exactly. This means we need to send the value of "playlist-enqueue" up to the master VLC.

If it's the only thing we need, we could simply add an int value to the beginning, if there's more, we'd need to have a generic scheme for passing {variable_name,variable_value} pairs to the master VLC.

And, "playlist-enqueue" is IMHO another hot candidate for b_unsaveable.

12/31/06 11:21:55 changed by zorglub

  • owner deleted.

06/21/07 23:30:58 changed by sambrightman

I think the most important use-case here is when VLC is set to only use one instance, and I would expect the solution to be less complex there. It just seems as if VLC is ignoring the command line and behaving the same either way. When in single instance mode: if set to not enqueue, there is no way to enqueue (without interrupting what's playing), if set to enqueue, there is no way to interrupt and start something new. This is infuriating. There also seems to be no separate enqueue action for files because of this, but perhaps that is a separate bug?

06/21/07 23:31:19 changed by sambrightman

  • cc changed from md, dionoea, hartman to md, dionoea, hartman, sambrightman.

09/23/07 21:43:03 changed by courmisch

(In [22251]) Mark playlist-enqueue as non-saveable - refs #869

09/23/07 21:43:44 changed by courmisch

  • keywords deleted.
  • version changed from 0.8.6 to HEAD.

09/23/07 22:07:07 changed by courmisch

  • status changed from new to assigned.
  • owner set to courmisch.

09/23/07 22:07:12 changed by courmisch

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [22252]) Pass --playlist-enqueue from started instance to running instance: fixes #869