directfb detection

http://flameeyes.is-a-geek.org:8080/~flame/vlc-patches/140_all_directfb.patch

Patch by Diego Petteno

Index: vlc-0.8.5-test2/configure.ac
===================================================================
--- vlc-0.8.5-test2.orig/configure.ac
+++ vlc-0.8.5-test2/configure.ac
@@ -3854,6 +3854,8 @@ dnl  DirectFB module
 dnl
 AC_ARG_ENABLE(directfb,
   [  --enable-directfb       DirectFB support (default disabled)])
+AC_ARG_WITH([directfb],
+  AC_HELP_STRING([--with-directfb=dir], [Base directory for DirectFB]))
 if test "${enable_directfb}" = "yes"
 then
   if test "${with_directfb}" = "no"

This is the quick way around, but it should be possible to fix this a lot more cleanly.

added Type::patch label

A new directfb detection

Added attachment:

• directfb_new_detect.patch

tests with this new detection

teste 1 'with-directfb'

#test with 'with-directfb'
./configure --disable-mad --enable-libmpeg2=no  --disable-wxwidgets --disable-skins2 --enable-directfb --with-directfb=/home/iuri/Devel/build/DirectFB-0.9.25.1/

#./vlc-config --libs plugin directfb
-L/usr/local/lib  -lpthread -L/home/iuri/Devel/build/DirectFB-0.9.25.1//lib/fusion/.libs/ -L/home/iuri/Devel/build/DirectFB-0.9.25.1//lib/direct/.libs/ -L/home/iuri/Devel/build/DirectFB-0.9.25.1//src/.libs/ -lz -ldl -ldirectfb -lfusion -ldirect -lpthread

some output

#./configure
checking directfb.h usability... yes
checking directfb.h presence... yes
checking for directfb.h... yes
checking for direct_initialize in -ldirect... yes
checking for fusion_enter in -lfusion... yes
checking for DirectFBInit in -ldirectfb... yes

#./vlc-config --libs plugin directfb
-L/usr/local/lib  -lpthread -L/usr/lib -ldirectfb -lfusion -ldirect -lpthread -lz -ldl

---

test 2 without 'with-directfb' (directfb-config)

#test without 'with-directfb' (directfb-config)
chmod +x /usr/bin/directfb-config

./configure --disable-mad --enable-libmpeg2=no --disable-wxwidgets --disable-skins2 --enable-directfb

some output

#./configure
checking for directfb-config... /usr/bin/directfb-config

#./vlc-config --libs plugin directfb

---

test 3 without 'with-directfb' (pkg-config)

#test without 'with-directfb' (pkg-config)

chmod -x /usr/bin/directfb-config

./configure --disable-mad --enable-libmpeg2=no --disable-wxwidgets --disable-skins2 --enable-directfb

# restore +x 
chmod -x /usr/bin/directfb-config

some output

#./configure
checking for DIRECTFB... yes

#./vlc-config --libs plugin directfb
-L/usr/local/lib  -lpthread -ldirectfb -lz -lfusion -ldirect -lpthread -ldl

added Status::works for me label

closed

removed Status::works for me label

reopened

I need more one person to test.

assigned to @iuridiniz

Replying to [comment:5 iuridiniz]:

I need more one person to test.

I have directfb installed on my system, using today's svn with that patch applied :

basic test :

$ ./configure --enable-directfb

[...] checking linux/fb.h usability... yes checking linux/fb.h presence... yes checking for linux/fb.h... yes checking for directfb-config... /usr/bin/directfb-config checking soundcard.h usability... no [...]

$ ./vlc-config --libs plugin directfb

-L/usr/local/lib -lpthread -L/usr/lib64 -ldirectfb -lfusion -ldirect -lpthread -lz -ldl

$ ./vlc-config --cxxflags plugin directfb

-I/usr/local/include -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -DLOCALEDIR="/usr/local/share/locale" -DDATA_PATH="/usr/local/share/vlc" -DPLUGIN_PATH="/usr/local/lib/vlc" -O3 -ffast-math -funroll-loops -mtune=athlon64 -fomit-frame-pointer -D__LIBVLC__ -D__PLUGIN__ -I/usr/include/directfb -D_REENTRANT -DMODULE_NAME=directfb -DMODULE_NAME_IS_directfb

now with -x on /usr/bin/directfb-config :

$ ./configure --enable-directfb [...] checking for linux/fb.h... yes checking for directfb-config... no checking for DIRECTFB... yes checking soundcard.h usability... no [...]

$ ./vlc-config --libs plugin directfb

-L/usr/local/lib -lpthread -ldirectfb -lz -lfusion -ldirect -lpthread -ldl

$ ./vlc-config --cxxflags plugin directfb

-I/usr/local/include -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -DLOCALEDIR="/usr/local/share/locale" -DDATA_PATH="/usr/local/share/vlc" -DPLUGIN_PATH="/usr/local/lib/vlc" -O3 -ffast-math -funroll-loops -mtune=athlon64 -fomit-frame-pointer -D__LIBVLC__ -D__PLUGIN__ -D_REENTRANT -I/usr/include/directfb -DMODULE_NAME=directfb -DMODULE_NAME_IS_directfb

Without the patch now :

$ ./configure --enable-directfb [...] checking for linux/fb.h... yes checking directfb.h usability... no checking directfb.h presence... no checking for directfb.h... no configure: error: cannot find directfb headers in /include

$ ./configure --enable-directdb --with-directfb=/usr

seems to detect it fine :

$ ./vlc-config --cxxflags plugin directfb -I/usr/local/include -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -DLOCALEDIR="/usr/local/share/locale" -DDATA_PATH="/usr/local/share/vlc" -DPLUGIN_PATH="/usr/local/lib/vlc" -O3 -ffast-math -funroll-loops -mtune=athlon64 -fomit-frame-pointer -D__LIBVLC__ -D__PLUGIN__ -I/usr/include -D_REENTRANT -DMODULE_NAME=directfb -DMODULE_NAME_IS_directfb

but.. since directfb.h is in /usr/include/directfb here, I get the following compilation error :

directfb.c:34:22: error: directfb.h: No such file or directory

nothing surprising

(In [21421]) Apply patch for directfb detection. Fix #845 (closed)

added Status::fixed label

closed