Ticket #789 (closed defect: wontfix)

Opened 2 years ago

Last modified 11 months ago

enabled extended gui makes resets all Video mode settings in menu to default

Reported by: trax Assigned to:
Priority: normal Milestone: WX bugs
Component: wxWidgets interface Version: 0.8.6 (bugfix)
Severity: normal Keywords: deinterlace menu extended gui
Cc: jb Platform(s): all
Difficulty: unknown Work status: Not started

Description

Video, Deinterlace -> Blend. Settings, Extended GUI -> Enable. This will turn off Deinterlace!

Video, Deinterlace -> Blend. This will function but will not appear in the menu.

In conclusion having the Extended GUI enabled switches off Deinterlace and will make the menu options not conform to the status of Deinterlace mode.

Change History

12/02/06 15:07:56 changed by funman

  • status changed from new to closed.
  • resolution set to fixed.

fixed in [18200]

12/03/06 07:57:45 changed by trax

  • status changed from closed to reopened.
  • resolution deleted.
  • severity changed from normal to blocker.

Tested with branch 18025 (0.8.6 rc1) the Deinterlace selection works/remains properly now with enabling Extended GUI, however when dragging any of the Image Adjust sliders like Brightness or Contrast to fullest they don't update the image immediately anymore. If you then select another Deinterlace mode it does refresh the image with the newly selected Brightness and Contrast values (so it seems to pull those var only at that time).

The updating of Brightness and Contract does work immediately when Deinterlace mode is set to disabled.

I consider this behaviour to be a regression at this late stage since you cannot visually see what you're setting those image values to so it has to be looked into before the release (or reverted).

12/03/06 08:01:59 changed by trax

  • priority changed from normal to highest.

Typo.. make that latest branch 18205..

12/03/06 12:32:35 changed by funman

  • severity changed from blocker to normal.

lowering severity as reverted to the old behaviour.

it seems extended gui & deinterlacing menu doesn't use the same settings: config variables versus runtime variables

12/03/06 12:44:39 changed by funman

  • priority changed from highest to normal.

12/03/06 17:03:26 changed by funman

In the wxwidgets interface, the deinterlacing can not be active in the same time than extended gui here's what happens:

< 18200 : deinterlacing mode is always lost when extended gui is active. this is because extended gui reads _config_ variable (config_GetPsz) "vout-filter", and deinterlacing menu modify _runtime_ variable (var_GetString).

>= 18200, < 18210 : extended gui now uses first runtime variable (var_GetString), and fallbacks on config variable (config_GetPsz) if it's empty.

deinterlacing mode is kept when extended gui is active. but extended gui settings will have no effects anymore.

I can't see the effects of deinterlacing, only see what's in the menu, and trax says deinterlacing is actually working, even if in the menu it looks disabled, so the behaviour of < 18200 is better.

12/08/06 10:34:01 changed by trax

  • summary changed from enabled extended gui makes deinterlace mode status in menu always disabled to enabled extended gui makes resets all Video mode settings in menu to default.

This also affects all other Video options: Crop, Post processing etc.

12/08/06 15:39:05 changed by hartman

  • milestone changed from 0.8.6 to 0.9.0 bugs.

05/01/07 13:30:19 changed by jb

  • cc set to jb.

Does it happens on Qt4 too ?

08/30/07 09:53:15 changed by funman

selecting deinterlace makes it crash: ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to objects owned by a different thread. Current thread 8868768. Receiver (of type 'VideoWidget?') was created in thread 843f4f8", file kernel/qcoreapplication.cpp, line 269

10/09/07 06:35:15 changed by funman

  • milestone changed from 0.9.0 bugs to WX bugs.

10/22/07 02:05:02 changed by jb

  • status changed from reopened to closed.
  • resolution set to wontfix.

10/22/07 02:05:18 changed by jb

Please create a new ticket for Qt4