Hebrew subtitles are encoded ISO-8859-8

Hebrew subtitles, as they are commonly found online, are mostly encoded ISO-8859-8.

But they seem to be decoded as UTF-8, which causes wrong characters.

Tested with 2.1.0~~git20120915+r2053-0r85quantal1 .

Downstream report: https://launchpad.net/bugs/1051552

Thanks, Shahar

added Component::Subtitles Platform::GNU/Linux Severity::normal Type::bug Version::master git labels

changed milestone to %Bugs paradize

Screenshot

Added attachment:

• 15.png

Original author: https://www.google.com/accounts/o8/id?id=aitoawl0jrsczj51bzrw2j4pbbzt4xzd58xw-5c

Duplicate issue. Works for me if I have only Hebrew subtitles file (ISO-8859-8) for a movie. At the moment, if you have several subtitles files (e.g. Hebrew and English) for a movie, they should be encoded as UTF-8.

added Status::duplicate label

closed

The following comment (comment:1) I posted was wrong. The issue was fixed on #6728 (closed). If your issue is different or the fix on #6728 (closed) doesn't help for you, please reopen the ticket. And please post the sample subtitles file and logs (messages with verbosity 2).

FYI, I play a blank movie with SubRip ISO-8859-8 and it works fine. Of course I set default encoding (Hebrew ISO-8859-8) and font (Arial Unicode MS) in the preferences.

My tested environment (all compiled from latest git source):

• Ubuntu 12.04: vlc-2.1.0, vlc-2.0.4
• Windows 7 64bit (win32/win64): vlc-2.1.0, vlc-2.0.4
• OS X 10.8.1: vlc-2.1.0, vlc-2.0.4 (both freetype2/quartztext)

The default setting is wrong for Hebrew. That's due to lack of any active Hebrew translator in the last few years.

removed Status::duplicate label

reopened

assigned to @Courmisch and unassigned @jbk

added 1 deleted label and removed Platform::GNU/Linux label

changed milestone to %2.0.4

added Status::fixed label

closed

commit f2d861c7 Author: Rémi Denis-Courmont remi@remlab.net Date: Sun Sep 16 20:42:15 2012 +0300

po: correct default encoding for Hebrew subtitles (fixes [#7474](https://code.videolan.org/videolan/vlc/-/issues/7474))

Original author: remi@remlab.net

Rémi,

That was record breaking response time for me.

May I please ask, how does the language get detected, please? In order for the correct encoding to be set, it must be detected that the subtitle file is in Hebrew. Is this right? I'm asking because GNOME's Totem video player seems to have the same issue and I'd like to point them to an example of correct behavior.

Thanks, Shahar

Original author: https://www.google.com/accounts/o8/id?id=aitoawl0jrsczj51bzrw2j4pbbzt4xzd58xw-5c

VLC selects a default non-Unicode character encoding based on the user language, in this case, Hebrew. If you view a non-Unicode Hebrew subtitle on an English system, you will need to select the encoding manually.

Rémi,

I was mistaken in my assumption that VLC chooses an encoding in some clever way.

I may have been mistaken in my assumption that Hebrew subtitles are ISO-8859-8. But not severely mistaken. It could also be Windows-1255. There's not much difference. But for the little difference that there is, it should be coded correctly.

Was it Windows-1255 before it was changed, Rémi?

Thanks, Shahar

Original author: https://www.google.com/accounts/o8/id?id=aitoawl0jrsczj51bzrw2j4pbbzt4xzd58xw-5c

No, it was CP1252 before. It was changed to CP1255 13 days ago.