Ticket #528 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Check all the opening of files respects To/FromLocale

Reported by: hartman Assigned to: courmisch
Priority: high Milestone:
Component: Version: master
Severity: major Keywords:
Cc: Platform(s): all
Difficulty: unknown Work status: Not started

Description

preferences files, subtitle detection and opening etc etc etc.

Change History

02/01/06 21:19:38 changed by hartman

subtitles autodetect seems to respect From/ToLocale. However, --sub-file MIGHT not respect it, especially on Windows. Someone needs to check.

Homedir is stored in default locale atm. does not appear to cause a problem at first sight.

02/01/06 21:24:46 changed by hartman

the fopen in the subtitles autodetect doesn't seem to do a ToLocale?. so detection should fail in that case.

02/01/06 21:51:18 changed by hartman

(In [14131]) * If input file in current dir specified, then retrieve CWD when we try to look for subtitle files. fixes #463 * When probing the autodetected files, probe them in the Locale, not in UTF-8. refs #528

02/07/06 21:39:22 changed by hartman

#536 was related to this.

02/11/06 01:34:40 changed by hartman

the .bin .cue VCDimage loading probably has an issue with this as well (vcd and vcdx)

02/11/06 16:05:39 changed by courmisch

  • status changed from new to assigned.
  • owner set to courmisch.

02/11/06 16:13:56 changed by courmisch

(In [14235]) vlc_fopen() wrapper including required file name conversion (refs #528, refs?\194?\160#543)

02/12/06 20:55:39 changed by courmisch

(In [14271]) - Fix opening of SVG file through a symbolic

(one must use stat() rather than lstat() to obtain the size of a file's content!)

- Use UTF-8 wrappers (refs #528)

02/12/06 23:45:05 changed by courmisch

(In [14278]) - mkdir Unicode wrapper (refs #543) - fix load/save of configuration and creation of configuration directory (refs #528)

02/13/06 09:30:56 changed by courmisch

(In [14281]) All Unicode fixes for fopen() (refs #528)

02/13/06 10:54:16 changed by courmisch

(In [14283]) Another bunch of Unicode file names fixes (refs #528)

02/13/06 11:30:31 changed by courmisch

(In [14284]) Further fopen() unicode fixes (refs #528)

skins2 and galaktos remain as I'm not sure how they (don't?) handle encodings.

http interface URL were purposedly not made to use Unicode. I'm open to suggestions on that one.

02/14/06 00:06:21 changed by courmisch

  • milestone changed from 0.8.5-test1 to 0.8.5 feature freeze.

It is the kind of changes that is likely to break things, and it has actually already broken some stuff in the very recent past.

Personnaly, I can't find any more file opening. I however suspect some libraries besides GnuTLS also expect filenames in local encoding, but there's no easy way to find the involved plugins.

03/01/06 10:57:51 changed by courmisch

  • status changed from assigned to closed.
  • resolution set to fixed.

03/01/06 10:59:33 changed by courmisch

There's no way we can check the whole source tree.

The obvious problematic function calls were fixed.

Please open more specific tickets for further issues.

03/02/06 16:19:33 changed by courmisch

(In [14573]) Locale fixes (refs #528) + clean up