rotate movie by pressing hot-key

added Component::Video: filters Difficulty::easy Severity::normal Type::feature Version::master git + 1 deleted label

changed milestone to %1.1.12

Is this feature abandoned? I am new to VLC project and i would like to give it a try because it doesn't seem difficult.

Noone has worked on it.

I have successfully coded this feature. I can send a patch for it.

When and how will the patch of stef.orovas be made available? I am looking forward to seeing it officially implemented as soon as possible. Maybe it could even be uploaded somewhere in the meantime?

Thank you very much.

We've not seen the patch.

Sorry for the delay. I was waiting for the project's approval. I will send it as soon as possible.

Stef, any news about the approval?

Original author: dominik kälin

I tried to code this feature but my code was not accepted. Sorry but i can't continue since my questions about my code were not answered by the mailing list.

If you really want this i can send you a copy of the vlc project in which i coded the rotation hotkeys.

These are bad news. I would really like to have this feature implemented in the main version.

I you could spend some time to send me your project, that would be great. Can you attach it here, or do you have some webspace where you can put it on? I don't like to share mail e-Mail in a public place.

Original author: dominik kälin

That's a feature I really need and I'm waiting for it for years now, I wonder why your code was rejected? ...but also why such feature is still not yet implemented in VLC?. Maybe we can start a branch spin-off of VLC project, based on your code and call it VLC-Extreme or something :-)

Anyway, missing hotkey to rotate the video is annoying, especially for photos because VLC simply does not respect EXIF and all my slideshows of photos+videos from iPhone are simply a waste of time because all media files are rotated randomly due to the fact that VLC does not automatically rotate based on video/photo metadata... what a shame. Anyway, also other recent changes to VLC started to be annoying that I'm thinking to switch to other media player, I think the UX has been recently destroyed with newest versions... but that's different story.

Replying to [comment:11 slajerek]:

That's a feature I really need and I'm waiting for it for years now, I wonder why your code was rejected? ...but also why such feature is still not yet implemented in VLC?. Maybe we can start a branch spin-off of VLC project, based on your code and call it VLC-Extreme or something :-)

Anyway, missing hotkey to rotate the video is annoying, especially for photos because VLC simply does not respect EXIF and all my slideshows of photos+videos from iPhone are simply a waste of time because all media files are rotated randomly due to the fact that VLC does not automatically rotate based on video/photo metadata... what a shame. Anyway, also other recent changes to VLC started to be annoying that I'm thinking to switch to other media player, I think the UX has been recently destroyed with newest versions... but that's different story.

First, VLC 2.2.0 will respect EXIF to auto-rotate your movies (it's not called EXIF, but anyway). Then, there has been almost no UX changes in VLC since years, so you really seem dishonest in your comment.

A hotkey would not solve the problem of (not) reading the orientation field from the EXIF meta-data, unless you would press the key (multiple times) for each and every single image...

VLC needs to parse the EXIF orientation field, is all. That is outside the scope of this bug report.

Ok, sorry, maybe I'm exaggerating a bit about UX, apologies - I just don't know to keep playlist floating in different window and on top, and I'm almost sure that was doable before. That's great news on the VLC 2.2.0! Thanks.

Anyway the hotkey would be anyway a good feature to have. And the above is not in scope of this report.

Replying to [comment:14 slajerek]:

Ok, sorry, maybe I'm exaggerating a bit about UX, apologies - I just don't know to keep playlist floating in different window and on top, and I'm almost sure that was doable before. That's great news on the VLC 2.2.0! Thanks.

Anyway the hotkey would be anyway a good feature to have. And the above is not in scope of this report.

If you have UX issues or regressions, file a bug report.

With 2.2.0, the hotkey shouldn't be necessary.

Ok, shouldn't be, but note that iPhone sometimes writes wrong information about the video rotation and sometimes it's flipped vertically, f.e. when recording is started with phone still in the pocket and when it was not set up for shot yet, that's quite common with my videos ;-) One can edit the video using QT to fix this, but anyway - the hotkey is still a handy feature because of that fact.

Btw. I've just downloaded nightly 2.2.0 and my photos are not rotated correctly (flipped vertically), the MacOS Preview shows it rotated properly.

I use the rotate option for video pretty often and would like to see this added. thanks

+1 for a rotate function.

Please

Replying to [comment:19 Weltraumfahrer]:

+1 for a rotate function.

== Please ==

lol.

But, your video does not auto-rotate?

lol.

But, your video does not auto-rotate?

Nope, and that's the point. Videos sometimes are not rotated properly and it's quite often. Thus that's why we need the rotate keyboard shortcut...?

Changing the video format while playing is very flaky in VLC so far. Adding a hotkey for rotation is like putting the cart before the horse.

Replying to [comment:22 courmisch]:

Changing the video format while playing is very flaky in VLC so far. Adding a hotkey for rotation is like putting the cart before the horse.

But there is a transformation option in vlc's settings. What's the process behind it and why is it so difficult to execute it with a hotkey?

Replying to [comment:23 stef.orovas]:

But there is a transformation option in vlc's settings.

And it is flaky.

Yes, it would be better, to have propper orientation infos embedded inside the video file. But the truth is: Many files doesn´t have them.

I use one of those gopro-clones for taking (breath taking) videos. :-)

It does not embed any orientation infos inside the video file. I gues they sell a lot of them, so I might not be the only one. An other usecase is changing the rotation while taking a video...

We have a lot of unperfect videos out there - that´s the reason we love a helpfull video-player, that can pull a cart AND a horse, no matter how they are oriented. ;)

Maybe someone can create a autohotkey script to execute a 90° rotation to the left? You can use it multiple times to rotate to the angle you need.

PS. After 7 Jägermeister my english gets better, yay! ᕕ( ᐛ )ᕗ

Replying to [comment:25 Weltraumfahrer]:

PS. After 7 Jägermeister my english gets better, yay! ᕕ( ᐛ )ᕗ

Boy, you win the Internet :) (or at least, this bugtracker)

Replying to [comment:24 courmisch]:

Replying to [comment:23 stef.orovas]:

But there is a transformation option in vlc's settings.

And it is flaky.

To be explicit, proper live rotation should swap the pixel dimensions and invert the SAR; the DAR is consequently inverted:

Rotated width = height
Rotated height = width
Rotated SAR = 1 / SAR

Instead, VLC live rotation keeps the pixel dimensions and adjust the SAR such that the DAR is inverted:

Rotated width = width
Rotated height = height
Rotated SAR = (height * height) / (width * width * SAR)

Either way, the DAR is rotated "correctly":

Rotated DAR = 1 / DAR

This obviously reduces the picture details a lot. It also consumes CPU at that (probably won't work at all for 4K). I also suspect it crashes or fails in some corner cases.

Hinted automatic rotation has none of those issues and can even be accelerated by the GPU.

'''I promise,

I will not try to rotate any 4K content.

...

Ever.'''

So when is this shortcut/button coming to VLC? *The feature is already there, it's just adding a shortcut for it, so it's easier to access! * If you think the feature is broken, then repair it. And the functionality of rotating videos is very important and used a lot, in this day an age, because of films recorded on smarthpones.

Yeah, if someone creates Autohotkey script, that would be a possible workaround for some time.

As no one of our VLC-friends (former heroes), takes care of essential user needs, here is a litte workaround that may help users with appropriate grafic card drivers:

I use a laptop with a Nvidia GPU and I can change the orientation of the screen by pressing ALTGr+Arrowup (or down, left, right). That rotates the whole screen inclusive the desktop etc. but in fullscreen - who cares?! ;-) After watching the video you have to rotate back to normal. Not elegant, but it works for me.

Nevertheless - a shortcut to rotate is still necessary for all the people who don´t have an appropriate GPU.

See #16605 (closed)

added Component::Interface: other plugins label and removed Component::Video: filters label

assigned to @tguillem and unassigned @MigrationBot

changed milestone to %4.0

Any update on this enhancement?

I am new here and would like to contribute. Can I work on this? Where should I start?

Hi, I have someone working on solving this ticket, but I'd like to validate the approach so as to guide him correctly.

1/ Implementation scope

I planned on having the user rotation intent conveyed like this:

hotkeys -> vout_thread (from vlc_player) -> vout_display

As a first step for him, it should mainly work with modules that are already able to handle rotation. Just like spu scaling, vout display can indicate that they support rotation by setting the correct info flag. Because we would have both the intent and original rotation, it would be easier to have the result right and recover when resetting, as well as displaying correct OSD messages. The patch will less likely break something too.

2/ improving to vout not supporting rotation

As a second step, it should probably add a rotation filter handling the composition of both original orientation and user rotation intent, in an additional filter_chain in vout_thread.

I'm still not completely sure where aspect ratio will be handled. I don't know if we really can have non-rotation-able but scaling-able vout (wayland/shm seems to say yes though) but like spu-scaling, letting the opportunity to the display to process it itself and fallback to vout_thread handling seems a good plan to me.

Is it correct ? Am I missing something ? Thanks.

Seems OK.

In current version the transformation works fine. Switches in real time with no issues. So would it be now possible to add a shortcut to rotate by 90 degrees on every hit of it?

rotate movie by pressing hot-key

Child items 0

Activity

Please