Win32: Keyboard Mute Button works since 1.1.0, but still partly broken
I'm using VLC 1.1.0 on Windows XP. In prior versions, the mute button did not work at all if VLC had focus. Now since 1.1.0 this works, but there is still a bug:
- Set Windows mixer to mute without VLC running
- Start VLC -> VLC schows its own mute button as unmuted
- Press the Mute button: -> Windows unmutes, but VLC mutes
So I have to remember to unmute before starting VLC. Alternatively, I can klick on the vlc mute icon and then use the Mute key of by multimedia keyboard.
Activity
added Component::Interface: other plugins label
assigned to @geal
changed milestone to %1.1.1
Replying to [comment:2 rknapp]:
I wonder why VLC catches the volume/mute keys at all - IMHO they are there to control my system and not my applications and therefore it makes sense for VLC to ignore these button events.
I rather wonder why VLC receives the event at all. On a sane windowing system, if an application grabs the mute key, then the focused application does not receive mute key events at all. So for example, the mixer application can grab the volume up, down and mute keys, and the other applications will never see them. But if the mixer application is absent, then the applications do get the events, and can handle the keys "locally".
added Status::fixed label
courmisch: Unfortunately the windowing system is as it is. We have to work around it.
jb: Where's the fix? I don't see a patch in the git repository.
This has the same route cause as 3828.
As suggested there, I believe VLC should also not change its volume by default in response to the system volume keys: up, down, or mute.
A simple patch for both was already submitted (link) but unfortunately not merged.
The only relevant patch I see is 597d48c13 'Qt: tell that vlc processed the media keys' in the vlc-1.1 repo.
That patch causes vlc to capture all the media button messages it receives, so they aren't processed by other apps. This means VLC volume will be modified by media buttons when VLC has focus, and system volume will be modified by media buttons when VLC does not have focus.
IMO this is confusing. Also, this is not the behaviour exhibited by other media players (incl. Windows Media Player, iTunes, Winamp) on Windows. Shouldn't VLC follow the standard behaviour? The patch I linked to does just that.
I don't believe the patch you've merged into the vlc-1.1 tree fixes the problem. That's why I wrote what I did. Apologies for any offence caused by being ambiguous. I can read git repos just fine :P.
We clearly disagree.
Most on this forum thread want VLC to ignore volume hotkeys. Does that count for anything?
If not, how about a configuration setting to choose between the two behaviours (vlc consumes volume changes when it has focus vs vlc ignoring volume changes)? I can write the code if that is acceptable.
If so, should VLC process PrntScr? How about the windows key? I have a sleep button on my keyboard, what should VLC do with that?Sure, they should be processed. And if we have nothing to do with them => ignore. Which is the correct behaviour.
If you want an option to not process media keys, this is fine, of course.
If you want an option to not process media keys, this is fine, of course.Only on VolUp, VolDown and Mute. No need to ignore other media keys. Its just about using volume keys to control only SYSTEM volume, and not PLAYER volume or BOTH at the same time. Thats the way other media players like WMP and WINAMP work.
Original author: Ben
Added attachment:
