Regression: --video-x and --video-y not working in 1.1

changed milestone to %1.1 bugs

changed title from --video-x and --video-y not working in nightlys to Regression: --video-x and --video-y not working in 1.1

This is still not working. I was attempting to modify the CreateWindow to be...

(line 541, modules/video_output/msw/events.c) (I think this is where it's created?)

        CreateWindowEx( WS_EX_NOPARENTNOTIFY | i_stylex,
                    _T("VLC DirectX"),               /* name of window class */
                    _T(VOUT_TITLE) _T(" (DirectX Output)"),  /* window title */
                    i_style,                                 /* window style */
-                    (p_event->wnd_cfg.x < 0) ? CW_USEDEFAULT :
-                        p_event->wnd_cfg.x,   /* default X coordinate */
-                    (p_event->wnd_cfg.y < 0) ? CW_USEDEFAULT :
-                        p_event->wnd_cfg.y,   /* default Y coordinate */
+                    (p_event->wnd_cfg.x == -1) ? CW_USEDEFAULT :
+                        p_event->wnd_cfg.x,   /* default X coordinate */
+                    (p_event->wnd_cfg.y == -1) ? CW_USEDEFAULT :
+                        p_event->wnd_cfg.y,   /* default Y coordinate */
                    rect_window.right - rect_window.left,    /* window width */
                    rect_window.bottom - rect_window.top,   /* window height */
                    p_event->hparent,                       /* parent window */
                    NULL,                          /* no menu in this window */
                    hInstance,            /* handle of this program instance */
                    (LPVOID)p_event );           /* send vd to WM_CREATE */

So that the vlc window can be positioned on the top/left monitor relative to the main desktop.

I added some debugging and wnd_cfg.x, .y is 0, 0 position always....

I see definitions for 'video-x' and 'video-y' but I never see them referenced for input? aren't variables accessed with the same strings to read them as they are to get defined?

the cfg.win.x is 0 when EventThreadStart is called...

in Direct3d.c

    memset(&cfg, 0, sizeof(cfg));
    cfg.use_desktop = sys->use_desktop;
    if (!sys->use_desktop) {
        cfg.win.x      = sys->desktop_save.win.left;
        cfg.win.y      = sys->desktop_save.win.top;
    }

The cfg.win.x, y are either 0 or some saved parameter...

assigned to @Courmisch

commit 0b220edc Author: Rémi Denis-Courmont remi@remlab.net Date: Sat Mar 6 18:48:43 2010 +0200

Win32: use video-x and video-y (fixes [#3215](https://code.videolan.org/videolan/vlc/-/issues/3215))

Original author: remi@remlab.net

added Status::fixed label

closed

vlc 1.1.4 in windows xp pro --video-x and --video-y not work from cmdline, I reopen the bug.

removed Status::fixed label

reopened

I would have aggreed seemed that it was not working in Widnows 7 either, however, with -I dummy --video-x and --video-y work correctly (even allowing positioning to the top and left screens). This seems to be an issue with the qt interface not respecting the location.

Qt4 never respected the video-x and video-y setting. We definitely don't want to move the whole UI on every video...

If you want to set the video position, you need to disable embedded mode.

added Status::fixed label

closed

Regression: --video-x and --video-y not working in 1.1

Child items 0

Activity