Ticket #1824 (closed defect: fixed)

Opened 4 months ago

Last modified 3 months ago

SAP parser discards valid announcements

Reported by: md Assigned to: courmisch
Priority: high Milestone: 0.9.0-test4
Component: Services discovery Version: master
Severity: major Keywords:
Cc: md Platform(s): Win32
Difficulty: unknown Work status: Not started

Description

There's some bug in SAP connection line parsing - valid announcements are discarded with:

sap debug: SDP connection infos not supported: IN IP4 233.10.47.89/20

This is a regression from 0.8.6

Change History

06/08/08 17:19:30 changed by md

  • summary changed from SAP parser discards valid announces to SAP parser discards valid announcements.

06/08/08 23:19:30 changed by hartman

Do you have a full SDP from SAP which causes this ?

07/08/08 08:27:06 changed by md

  • platform changed from all to Win32.

It's a SDP generated by the miniSAPserver...

Looking at the code, I suspect the problem is that inet_pton is now being used in modules/services_discovery/sap.c, but Win32 does not have it.

There is inet_pton replacement for Win32 in src/network/io.c - but it probably doesn't work.

09/08/08 10:50:37 changed by courmisch

  • status changed from new to assigned.
  • owner set to courmisch.

09/08/08 10:51:03 changed by courmisch

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed by 8cec5b2101b79e6a2717397378db94e0f0fbdd20

10/08/08 07:59:47 changed by md

  • status changed from closed to reopened.
  • resolution deleted.

Unfortunately still the same problem (trunk-20080810-0006 nighly build).

10/08/08 09:41:41 changed by courmisch

  • status changed from reopened to closed.
  • resolution set to fixed.

Fixed by e584675c5eb30e21b804476888f2e778612bc238