Ticket #1668 (closed defect: fixed)

Opened 2 months ago

Last modified 2 weeks ago

shoutcast items get deleted on play workaround --playlist-tree

Reported by: trax Assigned to: geal
Priority: normal Milestone: 0.9.0-test4
Component: Playlist Version: master
Severity: normal Keywords:
Cc: Platform(s): all
Difficulty: unknown Work status: Not started

Description

NB vlc-0.9.0-test2-20080702-1913-win32.zip. Shoutcast discovery of TV or radio listing fills the playlist but selecting Play will result in Deleting the item since it cannot be played. It will automatically skip to the next and repeat this Delete for every entry.

Workaround is to use --playlist-tree option.

Change History

07/15/08 02:34:58 changed by jb

  • milestone changed from 0.9.0-test2 to 0.9.0-test3.

07/22/08 22:01:23 changed by pdherbemont

I would set --playlist-tree always, and remove that option. The playlist onelevel<->category is very clever but not maintainable. This is a nasty hack and should be removed.

08/03/08 03:48:17 changed by jb

  • milestone changed from 0.9.0-test3 to 0.9.0-test4.

08/10/08 13:51:18 changed by pdherbemont

  • status changed from new to assigned.
  • owner set to pdherbemont.

I need more info here. Do you have a -vvv full output?

08/11/08 19:17:49 changed by Geal

Without --playlist-tree, when an item is played, vlc downloads the playlist for this item, deletes it, and adds all the items of this playlist to the playlist, at the same level as the old one.

main debug: rebuilding array of current - root Playlist
main debug: rebuild done - 0 items, index -1
main debug: starting new item
main debug: processing request item All node Shoutcast Radio skip 0
main debug: rebuilding array of current - root Shoutcast Radio
main debug: rebuild done - 380 items, index 14
main debug: creating new input thread
main debug: waiting for thread completion
main debug: thread started
main debug: thread 5120 (input) created at priority 1 (input/input.c:353)
main debug: `http/shout-winamp://www.shoutcast.com/sbin/newxml.phtml?genre=All' 
gives access `http' demux `shout-winamp' path `www.shoutcast.com/sbin/newxml.phtml?genre=All'
qt4 debug: I was here, updating your status
main debug: creating access 'http' path='www.shoutcast.com/sbin/newxml.phtml?genre=All'
main debug: looking for access module: 2 candidates
access_http debug: http: server='www.shoutcast.com' port=80 file='/sbin/newxml.phtml?genre=All
main debug: net: connecting to www.shoutcast.com port 80
main debug: connection: Resource temporarily unavailable
main debug: connection succeeded (socket = 5144)
access_http debug: protocol 'HTTP' answer code 200
access_http debug: Server: Apache
access_http debug: Transfer-Encoding: chunked
access_http debug: Content-Type: text/xml;charset=UTF-8
main debug: using access module "access_http"
main debug: TIMER module_Need() : 1059.000 ms - Total 1059.000 ms / 1 intvls (Avg 1059.000 ms)
main debug: Using AStream*Stream
main debug: pre-buffering...
main debug: received first data for our buffer
qt4 debug: New Event: type 1103
qt4 debug: I was here, updating your status
main debug: pre-buffering done 7250 bytes in 0s - 47 kbytes/s
main debug: creating demux: access='http' demux='shout-winamp' path='www.shoutcast.com/sbin/newxml.phtml?genre=All'
main debug: looking for demux module: 1 candidate
playlist debug: using shoutcast playlist reader
main debug: using demux module "playlist"
main debug: TIMER module_Need() : 0.000 ms - Total 0.000 ms / 1 intvls (Avg 0.000 ms)
main debug: looking for a subtitle file in c:\Users\geo\Documents\dev\vlc\vlc-0.9.0-git\
main debug: `http/shout-winamp://www.shoutcast.com/sbin/newxml.phtml?genre=All' successfully opened
main debug: looking for xml module: 2 candidates
qt4 debug: New Event: type 1103
main debug: using xml module "xml"
qt4 debug: I was here, updating your status
main debug: TIMER module_Need() : 0.000 ms - Total 0.000 ms / 1 intvls (Avg 0.000 ms)
main debug: deleting item `All'
main debug: marking All for further deletion
main debug: rebuilding array of current - root Shoutcast Radio
main debug: rebuild done - 388 items, index -1
main debug: no fetch required for Radio Guerrilla - La Unica Radio Con Cojones (art currently (null))
main debug: no fetch required for www.westindiesradio.net (art currently (null))
[...]
main debug: All was marked for deletion, deleting
main debug: starting new item
main debug: changing item without a request (current -1/670)
main debug: rebuilding array of current - root Shoutcast Radio
main debug: rebuild done - 749 items, index -1
main debug: using item 0
main debug: creating new input thread
main debug: waiting for thread completion
main debug: thread started
main debug: thread 5112 (input) created at priority 1 (input/input.c:353)
main debug: `http/shout-winamp://www.shoutcast.com/sbin/newxml.phtml?genre=24hs' 
gives access `http' demux `shout-winamp' path `www.shoutcast.com/sbin/newxml.phtml?genre=24hs'

Now, the subitems like westindiesradio.net are added at the end of the playlist, but vlc goes to item 0, parse it, appends items to the playlist, etc. With the one-level playlist, it will be hard to have a clear and intuitive look, as all the radios items would be at the same level. Having always --playlist-tree seems better.

I propose two ideas, if we keep the one-level playlist in Qt:

*make vlc switch to the first item of the playlist after it is deleted

*copy the genre in the metadata of radios in the playlist: with a sort, one cloud gather the radios with same genre.

08/12/08 02:07:42 changed by pdherbemont

  • status changed from assigned to new.
  • owner changed from pdherbemont to geal.

08/23/08 00:20:44 changed by jb

  • status changed from new to closed.
  • resolution set to fixed.