Ticket #1575 (closed defect: fixed)

Opened 9 months ago

Last modified 1 month ago

QT4 open dialog creates bad MRLs

Reported by: funman Assigned to: jb
Priority: normal Milestone: 0.9.0-final
Component: Qt interface Version: master
Severity: critical Keywords: confirmed
Cc: ILEoo, thresh Platform(s): all
Difficulty: medium Work status: Not started

Description

When using the Stream dialog, QT4 generates a wrong MRL for the input

responsible code is FileOpenPanel::updateMRL() in components/open_panels.cpp 

    QString mrl = "";
    foreach( QString file, dialogBox->selectedFiles() ) {
         mrl += "\"" + file + "\" ";
    }

"file " is not valid "file1 ""file 2 " is not valid either

I'm not aware that we can open 2 files in one mrl. If this is effectively not possible, this code must go away and opening of multiple items must be forbidden.

Change History

11/30/07 11:40:42 changed by courmisch

  • keywords set to confirmed.

Opening multiples files with a single MRL is not implemented (and would be difficult and hackish anyway).

05/08/08 22:21:17 changed by courmisch

  • milestone changed from 0.9.0-TP to 0.9.0-test1.

06/02/08 07:55:40 changed by jb

  • status changed from new to assigned.

06/02/08 07:57:08 changed by jb

Can you detail a bit more the issue ? Is the problem the space ?

06/02/08 08:00:54 changed by jb

  • component changed from Interfaces to Qt interface.

06/02/08 16:38:30 changed by courmisch

Instead of (pseudo-code): 

foreach (file, dialogBox->selectedFiles())
    mrl += "\"" + file + "\" ";

addplaylistitem(mrl);

the Qt4 interface should do something like: 

foreach (file, dialogBox->selectedFiles())
    addplaylistitem("\"" + file + "\");

The playlist/input code does not support adding multiple files in a single MRL.

06/20/08 21:11:32 changed by courmisch

  • cc set to ILEoo.

Was this not fixed? (except perhaps for subtitles, but as discussed opening multiples files with one sub does not make much sense). If so we can move it to paradize/0.9.1 IMHO.

06/21/08 07:23:00 changed by jb 

foreach( QString file, dialogBox->selectedFiles() ) {
         mrl += "\"" + file + "\" ";
    }

does create the mrl in the open_panels.cpp

But OpenDialog::finish() does 

        QStringList tempMRL = SeparateEntries( mrl );
        for( size_t i = 0; i < tempMRL.size(); i++ )
        {
          playlist_AddInput( THEPL, p_input, )
        }

So for me, except the one subtitle/many files issue, I don't see the problem.

Moreover, I retested with qt4 on linux and windows, with files with spaces and I don't have any issues...

06/22/08 15:40:42 changed by courmisch

  • milestone changed from 0.9.0-test1 to Bugs paradize.

07/23/08 15:39:55 changed by thresh

Still happens when using Streaming via the QT4 interface.

Adds extra "" to the MRL, so access_file is unable to open the file.

07/23/08 15:41:23 changed by thresh

  • cc changed from ILEoo to ILEoo, thresh.

07/25/08 00:48:52 changed by trax

I opened #1736 to mention opening a single file does not work anymore. It was closed as a duplicate but I see this ticket set to Bugs paradize and not 0.9. Current situation renders Stream and Convert / Save options useless and should be considered a regression with a higher milestone than just BP.

07/28/08 08:44:49 changed by jb

Status ?

07/28/08 10:17:14 changed by thresh

It's still the same with 67cc17320

07/28/08 17:48:03 changed by jb

  • severity changed from normal to critical.
  • milestone changed from Bugs paradize to 0.9.0-final.

This is critical for release

07/29/08 23:33:46 changed by jb

  • status changed from assigned to closed.
  • resolution set to fixed.