Ticket #1541 (closed patch: fixed)

Opened 5 months ago

Last modified 5 months ago

packet length in RTCP sender report is wrong

Reported by: littlesavage Assigned to: courmisch
Priority: normal Milestone: 0.9.0-TP
Component: Stream output Version: master
Severity: trivial Keywords: patch
Cc: Platform(s): all
Difficulty: easy Work status: Not started

Description

Little typo in modules/stream_out/rtcp.c

Length of source description packet should be in 32bit words - 1 but not in bytes: 

--- rtcp.c.orig 2008-03-29 18:40:23.000000000 +0000
+++ rtcp.c      2008-03-29 18:41:32.000000000 +0000
@@ -149,7 +149,8 @@
     while ((ptr - sdes) & 3) /* 32-bits padding */
         *ptr++ = 0;
-    SetWBE (lenptr, ptr - sdes);
+    assert ( (ptr-sdes) > 4);
+    SetWBE (lenptr, (ptr - sdes)/4 - 1);

     rtcp->length = ptr - rtcp->payload;
     return rtcp;

Change History

03/30/08 20:48:03 changed by xtophe

  • keywords set to patch.
  • owner set to jpsaman.

03/31/08 18:25:47 changed by jpsaman

  • owner changed from jpsaman to courmisch.

03/31/08 20:04:01 changed by courmisch

  • status changed from new to assigned.

03/31/08 20:43:44 changed by courmisch

  • status changed from assigned to closed.
  • resolution set to fixed.

fixed in [3826c41]