libi420_rgb_mmx_plugin.so contains text relocations on x86 due to absolute memory references being used in inline asm

libi420_rgb_mmx_plugin.so contains text relocations on x86, which I think is bad for shared objects for various reasons (mainly because this prevents marking TEXT pages readonly).

I'll attach a patch that will add the various memory references that are used to gcc inline asm input constraints, so that'll let it choose how to address them. It'll use relative to the pic register references in pic mode, and absolute references in non pic mode. This also removes the need to manually do (%pic) relative addressing on x86_64.

As a side effect, it might fix the build of this plugin on intel mac osx (though I cannot check this).

let gcc choose how to reference memory addresses

Added attachment:

• i420_mmx_pic.patch

changed milestone to %0.9.0 bugs

just a note that it would fail to build with -fforce-addr in cflags, but as seen on: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33713 and: http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01651.html

it seems its going away from future gcc releases due to the exact same problems.

added Component::Video: filters label

assigned to @funman

[6c50d21c]

added Status::fixed label

closed

breaks on OSX

i420_rgb16.c: In function 'I420_R5G5B5__0_9_0i':
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'

removed Status::fixed label

reopened

Using Xcode 3.1 solves this issue on Mac OS X. Xcode 3.0 shouldn't be used. Use either Xcode 2.4.1 or 3.1, but nothing in between.

added Status::will not fix label

closed

I guess applying the patch would close the ticket

removed Status::will not fix label

reopened

added Status::fixed label

closed

Replying to [comment:5 funman]:

breaks on OSX {{{ i420_rgb16.c: In function 'I420_R5G5B5__0_9_0i': i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in auto insurance quotes class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' i420_rgb16.c:503: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm' }}} I had the same problem and i solve it.Thanks