Ticket #1291 (closed enhancement: fixed)

Opened 10 months ago

Last modified 7 months ago

Add Speex RTP Support

Reported by: hawkinsw Assigned to: courmisch
Priority: normal Milestone: 0.9.0 features freeze
Component: Decoders Version: master
Severity: normal Keywords: rtp, speex
Cc: courmisch, jpsaman, fenrir Platform(s): all
Difficulty: unknown Work status: Not started

Description

This patch adds support for Speex stream encoding/decoding via RTP. The files changed are live555.cpp, dec.c (in the src), rtp.c and speex.c.

Attachments

live555.cpp.patch (1.3 kB) - added by hawkinsw on 09/13/07 15:46:22.
live555.cpp patch
dec.c.patch (0.5 kB) - added by hawkinsw on 09/13/07 15:47:56.
dec.c patch
speex.c.patch (10.8 kB) - added by hawkinsw on 09/20/07 22:30:28.
rtp.c.patch (3.5 kB) - added by hawkinsw on 09/20/07 22:31:28.

Change History

09/13/07 15:46:22 changed by hawkinsw

  • attachment live555.cpp.patch added.

live555.cpp patch

09/13/07 15:47:56 changed by hawkinsw

  • attachment dec.c.patch added.

dec.c patch

09/17/07 13:54:15 changed by jb

  • cc set to courmisch, jpsaman, fenrir.

Who has the knowledge to check/apply those ?

09/17/07 21:27:41 changed by courmisch

  • owner set to courmisch.
  • version set to HEAD.
  • milestone set to 0.9.0 features freeze.

See the mailing list. I would rather someone else review the dec.c change - Meuuh perhaps? In any case, I am waiting for rtp.c to handle MTU properly, which it currently does not.

09/17/07 21:27:54 changed by courmisch

  • status changed from new to assigned.

09/17/07 22:15:07 changed by hawkinsw

I am working on adding that support for MTU. It is not as easy as I would have thought, especially since the size of each frame is not static when encoded with variable-bit-rate under Speex. I will keep you posted as I work through this issue in the next few days.

09/20/07 22:30:28 changed by hawkinsw

  • attachment speex.c.patch added.

09/20/07 22:31:28 changed by hawkinsw

  • attachment rtp.c.patch added.

09/20/07 22:33:43 changed by hawkinsw

I just added a new copy of the speex.c.patch and rtp.c.patch files. These address the concerns of packets larger than the mtu. Please let me know if you have additional concerns that I can address.

Thanks! Will

09/22/07 16:53:55 changed by courmisch

(In [22213]) Support for decoding Speex from RTP - refs #1291 Patch by Williams Hawkins

09/22/07 16:54:42 changed by courmisch

(In [22214]) Use a different FOURCC for Speex from RTP (refs #1291), as it needs some specific processing in the decoder. Patch from William Hawkins

09/22/07 17:00:46 changed by courmisch

(In [22215]) Speex RTP payload format output - refs #1291

09/22/07 17:03:11 changed by courmisch

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [22216]) Last part of the Speex/RTP patch - fixes #1291

11/23/07 19:42:08 changed by benwillcox

Hello, This last changeset 22216 seems to have caused SPDIF audio output to stop working properly. Please see ticket 1352 for the details: https://trac.videolan.org/vlc/ticket/1352

Thanks! Ben