Changeset f8b8b4bfeb91ea2e4d55a68dd9fe7762e3a702d1

Show
Ignore:
Timestamp:
30/03/08 01:29:26 (8 months ago)
Author:
Pierre d'Herbemont <pdherbemont@free.fr>
git-committer:
Pierre d'Herbemont <pdherbemont@free.fr> 1206836966 +0100
git-parent:

[5b3a2948fe225056508a3420fff1da95a373e7af]

git-author:
Pierre d'Herbemont <pdherbemont@free.fr> 1206836966 +0100
Message:

stream: No use to vlc_object_yield() and object that create ourslef, and that a race could possibly corrupt in case of bad usage.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • src/input/stream.c

    r9d2636c rf8b8b4b  
    17261726    if( p_input ) 
    17271727    { 
    1728         vlc_object_yield( p_input ); 
    17291728        vlc_mutex_lock( &p_input->p->counters.counters_lock ); 
    17301729        stats_UpdateInteger( s, p_input->p->counters.p_read_bytes, i_read, &i_total ); 
    …… 
    17331732        stats_UpdateInteger( s, p_input->p->counters.p_read_packets, 1, NULL ); 
    17341733        vlc_mutex_unlock( &p_input->p->counters.counters_lock ); 
    1735         vlc_object_release( p_input ); 
    17361734    } 
    17371735    return i_read; 
    …… 
    17571755        if( p_input &&  p_block && p_access->p_libvlc->b_stats ) 
    17581756        { 
    1759             vlc_object_yield( p_input ); 
    17601757            vlc_mutex_lock( &p_input->p->counters.counters_lock ); 
    17611758            stats_UpdateInteger( s, p_input->p->counters.p_read_bytes, 
    …… 
    17651762            stats_UpdateInteger( s, p_input->p->counters.p_read_packets, 1, NULL ); 
    17661763            vlc_mutex_unlock( &p_input->p->counters.counters_lock ); 
    1767             vlc_object_release( p_input ); 
    17681764        } 
    17691765        return p_block; 
    …… 
    17981794        if( p_input ) 
    17991795        { 
    1800             vlc_object_yield( p_input ); 
    18011796            vlc_mutex_lock( &p_input->p->counters.counters_lock ); 
    18021797            stats_UpdateInteger( s, p_input->p->counters.p_read_bytes, 
    …… 
    18071802                                 1 , NULL); 
    18081803            vlc_mutex_unlock( &p_input->p->counters.counters_lock ); 
    1809             vlc_object_release( p_input ); 
    18101804        } 
    18111805    }