Changeset f06a603621a4ff672e760a698a75f15d28da6c75

Timestamp:

10/03/07 23:07:01 (1 year ago)

Author:

Rafaël Carré <funman@videolan.org>

git-committer:

Rafaël Carré <funman@videolan.org> 1191445621 +0000

git-parent:

[f3fce2ada1f86438b566a73379b34c7028e1d06b]

git-author:

Rafaël Carré <funman@videolan.org> 1191445621 +0000

Message:

taglib: warn the user when the embedded image is invalid (i.e. was embedded by a broken version of iTunes)

Files:

• modules/meta_engine/taglib.cpp (modified) (1 diff)

modules/meta_engine/taglib.cpp

@@ -120 +120 @@
-
-            psz_mime = p_apic->mimeType().toCString(true);
+
+            /* some old iTunes version not only sets incorrectly the mime type
+             * but also embeds incorrectly the image.
+             * Recent versions seem to behave correctly */
+            if( !strncmp( psz_mime, "PNG", 3 ) )
+            {
+                msg_Warn( p_demux,
+                    "%s: Invalid picture embedded by broken iTunes version",
+                    f.file()->name() );
+                break;
+            }
+
-            psz_description = p_apic->description().toCString(true);
-            psz_name = psz_description;