Changeset e4e9182903c4915dd0c1e73eff6b325f0d3be54d

Timestamp:

03/30/08 16:15:09 (5 months ago)

Author:

Rémi Denis-Courmont <rem@videolan.org>

git-committer:

Rémi Denis-Courmont <rem@videolan.org> 1206886509 +0300

git-parent:

[30267d389073ee38e29728d0246ef5106e9e1f1a]

git-author:

Rémi Denis-Courmont <rem@videolan.org> 1206885955 +0300

Message:

Do NOT destroy the "libvlc"/global/bank/whatever lock variable.

The whole point of a global lock is that it is... global. Destroying it
every time it's released is severe brain damage, as we end up taking a
different lock all the time (or worse destroying the lock while another
threads is competing for it).

Files:

• src/libvlc-common.c (modified) (2 diffs)
• src/modules/modules.c (modified) (5 diffs)

src/libvlc-common.c

@@ -178 +178 @@
-    }
-    vlc_mutex_unlock( lockval.p_address );
-    var_Destroy( p_libvlc_global, "libvlc" );
-
-    /* Allocate a libvlc instance object */
@@ -1057 +1056 @@
-    }
-    vlc_mutex_unlock( lockval.p_address );
-    var_Destroy( p_libvlc_global, "libvlc" );
-
-    msg_Flush( p_libvlc );

src/modules/modules.c

@@ -148 +148 @@
-
-    vlc_mutex_unlock( lockval.p_address );
-    var_Destroy( p_libvlc_global, "libvlc" );
-
-}
-
@@ -173 +171 @@
-    {
-        vlc_mutex_unlock( lockval.p_address );
-        var_Destroy( p_libvlc_global, "libvlc" );
-        return;
-    }
@@ -179 +176 @@
-    {
-        vlc_mutex_unlock( lockval.p_address );
-        var_Destroy( p_libvlc_global, "libvlc" );
-        return;
-    }
-    vlc_mutex_unlock( lockval.p_address );
-    var_Destroy( p_libvlc_global, "libvlc" );
-
-    /* Save the configuration */
@@ -262 +257 @@
-    {
-        vlc_mutex_unlock( lockval.p_address );
-        var_Destroy( p_libvlc_global, "libvlc" );
-        return;
-    }
-    p_libvlc_global->p_module_bank->b_builtins = VLC_TRUE;
-    vlc_mutex_unlock( lockval.p_address );
-    var_Destroy( p_libvlc_global, "libvlc" );
-
-    msg_Dbg( p_this, "checking builtin modules" );
@@ -293 +286 @@
-    {
-        vlc_mutex_unlock( lockval.p_address );
-        var_Destroy( p_libvlc_global, "libvlc" );
-        return;
-    }
-    p_libvlc_global->p_module_bank->b_plugins = VLC_TRUE;
-    vlc_mutex_unlock( lockval.p_address );
-    var_Destroy( p_libvlc_global, "libvlc" );
-
-    msg_Dbg( p_this, "checking plugin modules" );