Changeset da6732062b23f833e860da223901eeeb75eefaf7

Timestamp:

07/05/08 13:22:09 (2 months ago)

Author:

Rémi Denis-Courmont <rdenis@simphalempin.com>

git-committer:

Rémi Denis-Courmont <rdenis@simphalempin.com> 1215256929 +0300

git-parent:

[06e3b333dcadd50c4e335337ac852918331499ca]

git-author:

Rémi Denis-Courmont <rdenis@simphalempin.com> 1215256929 +0300

Message:

vlc_object_alive: lock-less and inlined

Files:

• include/vlc_objects.h (modified) (1 diff)
• src/libvlccore.sym (modified) (1 diff)
• src/misc/objects.c (modified) (2 diffs)

include/vlc_objects.h

@@ -163 +163 @@
-    __vlc_object_kill( VLC_OBJECT(a) )
-
-
+
+
+
+
+
+
-#define vlc_object_alive(a) \
-    __vlc_object_alive( VLC_OBJECT(a) )

src/libvlccore.sym

@@ -434 +434 @@
-vlc_mutex_init
-vlc_mutex_init_recursive
-__vlc_object_alive
-__vlc_object_attach
-__vlc_object_create

src/misc/objects.c

@@ -548 +548 @@
-
-/**
- * Checks whether an object has been "killed".
- * The object lock must be held.
- *
- * Typical code for an object thread could be:
- *
-   vlc_object_lock (self);
-   ...initialization...
-   while (vlc_object_alive (self))
-   {
-       ...preprocessing...
-
-       vlc_object_wait (self);
-
-       ...postprocessing...
-   }
-   ...deinitialization...
-   vlc_object_unlock (self);
- *
- *
- * @return true iff the object has not been killed yet
- */
-bool __vlc_object_alive( vlc_object_t *obj )
-{
-    vlc_assert_locked( &(vlc_internals(obj)->lock) );
-    return !obj->b_die;
-}
-
-
-/**
- * Signals an object for which the lock is held.
- * At least one thread currently sleeping in vlc_object_wait() or
@@ -614 +585 @@
-
-    vlc_object_signal_unlocked( p_this );
+    /* This also serves as a memory barrier toward vlc_object_alive(): */
-    vlc_object_unlock( p_this );
-}