Changeset d215ca3f3504e426bb1b8779a7bc391fb19cdfff

Timestamp:

03/25/07 11:56:25 (1 year ago)

Author:

Rémi Denis-Courmont <rem@videolan.org>

git-committer:

Rémi Denis-Courmont <rem@videolan.org> 1174816585 +0000

git-parent:

[619f831bebde76ee6582262ac75be923b82615ee]

git-author:

Rémi Denis-Courmont <rem@videolan.org> 1174816585 +0000

Message:

Block SIGCHLD so we don't get polluted by system() in another thread[1]
(though this seem to only happen with debuggers and (?)broken OSes)

[1] system() blocks SIGCHLD, and is probably not intended for multithreading

We cannot assume that blocking calls in other libraries ignore EINTR anyway,
so the only safe approach is to block in all threads (you can unblock it in
your thread if you really want it) except the signal handling thread.

Files:

• src/network/io.c (modified) (2 diffs)
• src/vlc.c (modified) (1 diff)

src/network/io.c

@@ -293 +293 @@
-        {
-            case -1:
-                if( errno == EINTR )
-                    continue;
-                goto error;
-
@@ -443 +441 @@
-        {
-            case -1:
-                if( errno == EINTR )
-                    continue;
-               msg_Err (p_this, "Write error: %s", net_strerror (net_errno));
-               goto out;

src/vlc.c

@@ -104 +104 @@
-    static const int sigs[] = { SIGINT, SIGHUP, SIGQUIT, SIGTERM };
-    /* Ignored signals */
-
+, SIGCHLD
-
-    sigset_t set;