Changeset c6b6537f4d82d799bb4ee6d4c8c1dc6b87c0542c

Timestamp:

12/12/07 20:47:39 (9 months ago)

Author:

Rémi Denis-Courmont <rem@videolan.org>

git-committer:

Rémi Denis-Courmont <rem@videolan.org> 1197488859 +0000

git-parent:

[6c62642f455bfabd4a8c63fa6af0ee0d913ad703]

git-author:

Rémi Denis-Courmont <rem@videolan.org> 1197488859 +0000

Message:

Clear signal mask _between_ fork() and exec*().
Before fork() would break VLC's own sigmask.
After exec*() would rely on the children program to do it (and many don't).

Files:

• modules/misc/screensaver.c (modified) (2 diffs)
• src/extras/libc.c (modified) (2 diffs)

modules/misc/screensaver.c

@@ -135 +135 @@
-static void Execute( intf_thread_t *p_this, const char *const *ppsz_args )
-{
-
-= fork() 
+ = fork()
+
-    {
-        case 0:     /* we're the child */
+        {
+            sigset_t set;
+            sigemptyset (&set);
+            pthread_sigmask (SIG_SETMASK, &set, NULL);
+
-            /* We don't want output */
-            freopen( "/dev/null", "w", stdout );
@@ -144 +149 @@
-            execv( ppsz_args[0] , (char *const *)ppsz_args );
-            /* If the file we want to execute doesn't exist we exit() */
-1
-    break;
+EXIT_FAILURE
+}
-        case -1:    /* we're the error */
-            msg_Dbg( p_this, "Couldn't fork() while launching %s",

src/extras/libc.c

@@ -954 +954 @@
-
-        case 0:
+        {
+            sigset_t set;
+            sigemptyset (&set);
+            pthread_sigmask (SIG_SETMASK, &set, NULL);
+
-            /* NOTE:
-             * Like it or not, close can fail (and not only with EBADF)
@@ -963 +968 @@
-                execve (ppsz_argv[0], ppsz_argv, ppsz_env);
-
-
+
+
-    }
-