Changeset a6a9c37e7d3d24ae6abb50561e1ea8a7b476ac0d

Show
Ignore:
Timestamp:
05/15/08 18:58:57 (4 months ago)
Author:
Rémi Denis-Courmont <rem@videolan.org>
git-committer:
Rémi Denis-Courmont <rem@videolan.org> 1210870737 +0300
git-parent:

[84d0f814c4aaeb01141e993879de1ce8b0c7fedb]

git-author:
Rémi Denis-Courmont <rem@videolan.org> 1210870737 +0300
Message:

Don't bother with vlc_object_get() when you can keep pointers!

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • modules/gui/wxwidgets/dialogs/preferences.cpp

    r449fd28 ra6a9c37  
    135135    wxBoxSizer *sizer; 
    136136 
     137    module_t *p_module; 
    137138    int i_object_id; 
    138139    int i_subcat_id; 
     
    585586#endif 
    586587        config_data->i_type = TYPE_MODULE; 
    587         config_data->i_object_id = config_data->b_submodule ? 
    588             ((vlc_object_t *)p_module)->p_parent->i_object_id : 
    589             ((vlc_object_t *)p_module)->i_object_id; 
     588        config_data->p_module = config_data->b_submodule ? 
     589            p_module->p_parent : p_module; 
    590590        config_data->psz_help = NULL; 
    591591 
     
    770770                config_new = (ConfigTreeData *)GetItemData( module ); 
    771771                if( config_new && !config_new->b_submodule && 
    772                     config_new->i_object_id == config_data->i_object_id
     772                    config_new->p_module == config_data->p_module
    773773                { 
    774774                    return config_new; 
     
    900900        if( config_data->i_type == TYPE_MODULE ) 
    901901        { 
    902             p_module = (module_t *) 
    903                 vlc_object_get( config_data->i_object_id ); 
     902            p_module = config_data->p_module; 
    904903        } 
    905904        else