Changeset 8b270041340d60f49902be5d990766c7c288f869

Timestamp:

29/05/08 21:30:36 (4 months ago)

Author:

Rémi Denis-Courmont <rem@videolan.org>

git-committer:

Rémi Denis-Courmont <rem@videolan.org> 1212089436 +0300

git-parent:

[debed14afc143e80839ba97b92ea5be332c4ed51]

git-author:

Rémi Denis-Courmont <rem@videolan.org> 1212080470 +0300

Message:

Block all signals in VLC threads

Files:

• src/misc/threads.c (modified) (2 diffs)

src/misc/threads.c

@@ -36 +36 @@
-# include <unistd.h>
-#endif
+#include <signal.h>
-
-#define VLC_THREADS_UNINITIALIZED  0
@@ -472 +473 @@
-
-#if defined( LIBVLC_USE_PTHREAD )
+    sigset_t set, oldset;
+
+    /* We really don't want signals to (literaly) interrupt our blocking I/O
+     * system calls. SIGPIPE is especially bad, as it can be caused by remote
+     * peers through connected sockets. Generally, we cannot know which signals
+     * are handled by the main program. Also, external LibVLC bindings tend not
+     * to setup a proper signal mask before invoking LibVLC.
+     * Hence, we hereby block all signals, except those for which blocking is
+     * undefined, as listed below. Note that SIGKILL and SIGSTOP need not be
+     * listed (see the documentation for pthread_sigmask) here. */
+    sigfillset (&set);
+    sigdelset (&set, SIGFPE);
+    sigdelset (&set, SIGILL);
+    sigdelset (&set, SIGSEGV);
+    sigdelset (&set, SIGBUS);
+    pthread_sigmask (SIG_BLOCK, &set, &oldset);
+
-    i_ret = pthread_create( &p_priv->thread_id, NULL, thread_entry, boot );
+    pthread_sigmask (SIG_SETMASK, &oldset, NULL);
-
-#ifndef __APPLE__