Changeset 6c11c08a800fa57846e69fb86a42164f2570dfe4

Timestamp:

04/08/07 19:28:18 (1 year ago)

Author:

Rémi Denis-Courmont <rem@videolan.org>

git-committer:

Rémi Denis-Courmont <rem@videolan.org> 1186248498 +0000

git-parent:

[4c4c4ce26e381d5e03b016d384e84d8a94721685]

git-author:

Rémi Denis-Courmont <rem@videolan.org> 1186248498 +0000

Message:

Partially abstract module_t: add module_IsCapable()

Files:

• include/vlc_modules.h (modified) (4 diffs)
• src/libvlc.sym (modified) (1 diff)
• src/modules/modules.c (modified) (3 diffs)

include/vlc_modules.h

@@ -47 +47 @@
- * Module descriptor
- */
+/* FIXME: scheduled for privatization */
-struct module_t
-{
@@ -66 +67 @@
-    const char *pp_shortcuts[ MODULE_SHORTCUT_MAX ];
-
-onst char    *psz_capability;
+har    *psz_capability;      
-    int      i_score;                          /**< Score for the capability */
-    uint32_t i_cpu;                           /**< Required CPU capabilities */
@@ -111 +112 @@
-VLC_EXPORT( int, vlc_module_set, (module_t *module, int propid, void *value) );
-
-
+ vlc_module_properties
-{
-    /* DO NOT EVER REMOVE, INSERT OR REPLACE ANY ITEM! It would break the ABI!
@@ -129 +130 @@
-};
-
+VLC_EXPORT( vlc_bool_t, module_IsCapable, ( const module_t *, const char *cap ) );

src/libvlc.sym

@@ -178 +178 @@
-__module_Need
-__module_Unneed
+module_IsCapable
-__msg_Dbg
-__msg_Err

src/modules/modules.c

@@ -385 +385 @@
-
-/*****************************************************************************
+ * module_IsCapable: checks whether a module implements a capability.
+ *****************************************************************************/
+vlc_bool_t module_IsCapable( const module_t *m, const char *cap )
+{
+    return !strcmp( m->psz_capability, cap );
+}
+
+/*****************************************************************************
- * module_Need: return the best module function, given a capability list.
- *****************************************************************************
@@ -480 +488 @@
-
-        /* Test that this module can do what we need */
-strcmp( p_module->psz_capability
+!module_IsCapable( p_module
-        {
-            /* Don't recurse through the sub-modules because vlc_list_find()
@@ -1200 +1208 @@
-
-    free( (void*)p_module->psz_object_name );
-(void*)
+
-    free( (void*)p_module->psz_shortname );
-    free( (void*)p_module->psz_longname );