Changeset 587910d68cda330158f4c00cad82eac7c613666a

Timestamp:

10/05/08 00:16:28 (5 months ago)

Author:

Rafaël Carré <funman@videolan.org>

git-committer:

Rafaël Carré <funman@videolan.org> 1210371388 +0200

git-parent:

[e0321a0012f71020597f303d8d417ad23d88d011]

git-author:

Rafaël Carré <funman@videolan.org> 1210371388 +0200

Message:

Revert "Fix memleak in mpga demuxer"

This reverts commit 9a90c961a6d1c670a9e282c99ea8da0ba7688eab.
This introduces double free
I tend to prefer a memleak as a race condition rather than a crash

Files:

• modules/demux/mpeg/mpga.c (modified) (2 diffs)

modules/demux/mpeg/mpga.c

@@ -274 +274 @@
-        p_sys->b_start = false;
-        p_block_in = p_sys->p_block_in;
+        p_sys->p_block_in = NULL;
-        p_block_out = p_sys->p_block_out;
+        p_sys->p_block_out = NULL;
-    }
-    else
@@ -326 +328 @@
-    DESTROY_PACKETIZER( p_sys->p_packetizer );
-    if( p_sys->p_block_out ) block_Release( p_sys->p_block_out );
-    if( p_sys->p_block_in ) block_Release( p_sys->p_block_in );
-
-    free( p_sys );