Changeset 48c51ebb1336aac7ebb026a128457828782a87d6

Timestamp:

31/05/08 22:56:19 (4 months ago)

Author:

Rémi Denis-Courmont <rdenis@simphalempin.com>

git-committer:

Rémi Denis-Courmont <rdenis@simphalempin.com> 1212267379 +0300

git-parent:

[070e3454880e849f3ebca21d5f803cdd13351049]

git-author:

Rémi Denis-Courmont <rdenis@simphalempin.com> 1212267379 +0300

Message:

The not-so-dumb references checker

I saw you, evil preparser thread...

Files:

• src/misc/objects.c (modified) (3 diffs)

src/misc/objects.c

@@ -1556 +1556 @@
-        return;
-
-
+s
-    vlc_object_t *caller = vlc_threadobj ();
-    if (caller == obj)
-        return;
-
+
-    /* The calling thread is younger than the object.
-     * Access could be valid through cross-thread synchronization;
@@ -1566 +1566 @@
-    if (caller && (caller->i_object_id > obj->i_object_id))
-        return;
-
+
-    int refs;
-    vlc_spin_lock (&priv->ref_spin);
@@ -1572 +1572 @@
-    vlc_spin_unlock (&priv->ref_spin);
-
-/* Object has more than one reference.
-* The current thread could be holding a valid reference. */
-if (refs > 1
-
+for (held_list_t *hlcur = vlc_threadvar_get (&held_objects);
+    hlcur != NULL; hlcur = hlcur->next)
+    if (hlcur->obj == obj
+    
-
-    fprintf (stderr, "The %s %s thread object is accessing...\n"
-in a suspicous manner
+without references
-             caller && caller->psz_object_name
-                     ? caller->psz_object_name : "unnamed",