Changeset 44370bcc9dc567fe04089e1be460829ac5ebc289

Timestamp:

11/08/08 22:31:28 (4 months ago)

Author:

Rémi Duraffort <ivoire@videolan.org>

git-committer:

Rémi Duraffort <ivoire@videolan.org> 1218486688 +0200

git-parent:

[cef1653682e2b9b766f5b272bd5d180b44b976fa]

git-author:

Rémi Duraffort <ivoire@videolan.org> 1218486688 +0200

Message:

Fix memleak, check return value.

Files:

• modules/audio_filter/equalizer.c (modified) (5 diffs)

modules/audio_filter/equalizer.c

@@ -173 +173 @@
-    /* Allocate structure */
-    p_sys = p_filter->p_sys = malloc( sizeof( aout_filter_sys_t ) );
+    if( !p_sys )
+        return VLC_ENOMEM;
-
-    if( EqzInit( p_filter, p_filter->input.i_rate ) )
+    {
+        free( p_sys );
-        return VLC_EGENERIC;
+    }
-
-    return VLC_SUCCESS;
@@ -359 +364 @@
-    p_sys->b_first = false;
-
+    free( val1.psz_string );
+
-    /* Register preset bands (for intf) if : */
-    /* We have no bands info --> the preset info must be given to the intf */
@@ -365 +372 @@
-    {
-        msg_Err(p_filter, "No preset selected");
+        free( val2.psz_string );
-        return (VLC_EGENERIC);
-    }
@@ -374 +382 @@
-            var_SetFloat( p_aout, "equalizer-preamp", p_sys->f_newpreamp );
-    }
+    free( val2.psz_string );
-
-    /* Add our own callbacks */
@@ -468 +477 @@
-
-    free( p_sys->f_amp );
+    free( p_sys->psz_newbands );
-}
-