Changeset 2f65bd42d2c22389b33982d0c1b62afc790b7941

Show
Ignore:
Timestamp:
02/01/07 22:50:30 (2 years ago)
Author:
Rémi Denis-Courmont <rem@videolan.org>
git-committer:
Rémi Denis-Courmont <rem@videolan.org> 1167774630 +0000
git-parent:

[b11fb39b618411a952b1ee7593a1cdfb37438000]

git-author:
Rémi Denis-Courmont <rem@videolan.org> 1167774630 +0000
Message:

Fix a bunch of format string injection in VCDX and CDDA.
Initially reported by Kevin Finisterre

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • modules/access/cdda/access.c

    r075b164 r2f65bd4  
    9393        case CDIO_LOG_INFO: 
    9494            if (p_cdda->i_debug & INPUT_DBG_CDIO) 
    95             msg_Dbg( p_cdda_input, message); 
     95            msg_Dbg( p_cdda_input, "%s", message); 
    9696            break; 
    9797        case CDIO_LOG_WARN: 
    98             msg_Warn( p_cdda_input, message); 
     98            msg_Warn( p_cdda_input, "%s", message); 
    9999            break; 
    100100        case CDIO_LOG_ERROR: 
    101101        case CDIO_LOG_ASSERT: 
    102             msg_Err( p_cdda_input, message); 
     102            msg_Err( p_cdda_input, "%s", message); 
    103103            break; 
    104104        default: 
    105             msg_Warn( p_cdda_input, message, 
     105            msg_Warn( p_cdda_input, "%s\n%s %d", message, 
    106106                    "the above message had unknown cdio log level", 
    107107                    level); 

  • modules/access/vcdx/access.c

    ra29a4e2 r2f65bd4  
    9292  case CDIO_LOG_INFO: 
    9393    if (p_vcdplayer->i_debug & INPUT_DBG_CDIO) 
    94       msg_Dbg( p_vcd_access, message); 
     94      msg_Dbg( p_vcd_access, "%s", message); 
    9595    break; 
    9696  case CDIO_LOG_WARN: 
    97     msg_Warn( p_vcd_access, message); 
     97    msg_Warn( p_vcd_access, "%s", message); 
    9898    break; 
    9999  case CDIO_LOG_ERROR: 
    100100  case CDIO_LOG_ASSERT: 
    101     msg_Err( p_vcd_access, message); 
     101    msg_Err( p_vcd_access, "%s", message); 
    102102    break; 
    103103  default: 
    104     msg_Warn( p_vcd_access, message, 
     104    msg_Warn( p_vcd_access, "%s\n%s %d", message, 
    105105            _("The above message had unknown log level"), 
    106106            level); 
    …… 
    118118  case VCD_LOG_INFO: 
    119119    if (p_vcdplayer->i_debug & INPUT_DBG_VCDINFO) 
    120       msg_Dbg( p_vcd_access, message); 
     120      msg_Dbg( p_vcd_access, "%s", message); 
    121121    break; 
    122122  case VCD_LOG_WARN: 
    123     msg_Warn( p_vcd_access, message); 
     123    msg_Warn( p_vcd_access, "%s", message); 
    124124    break; 
    125125  case VCD_LOG_ERROR: 
    126126  case VCD_LOG_ASSERT: 
    127     msg_Err( p_vcd_access, message); 
     127    msg_Err( p_vcd_access, "%s", message); 
    128128    break; 
    129129  default: