Changeset 17afdb9122177e7dd1a974c26d9948c1dbfd4e18

Show
Ignore:
Timestamp:
08/29/06 13:27:38 (2 years ago)
Author:
Jean-Paul Saman <jpsaman@videolan.org>
git-committer:
Jean-Paul Saman <jpsaman@videolan.org> 1156850858 +0000
git-parent:

[1d0b15b5cb9fae31bdc56931a0167556cc4ebe92]

git-author:
Jean-Paul Saman <jpsaman@videolan.org> 1156850858 +0000
Message:

Cleanup

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • modules/audio_filter/converter/mono.c

    r1d0b15b r17afdb9  
    104104  AOUT_CHAN_CENTER, AOUT_CHAN_LFE, 0 }; 
    105105 
    106 #define MONO_CFG "sout-
     106#define MONO_CFG "sout-mono-
    107107/***************************************************************************** 
    108108 * Module descriptor 
     
    112112    set_capability( "audio filter2", 5 ); 
    113113 
    114     add_bool( MONO_CFG "mono-downmix", VLC_FALSE, NULL, MONO_DOWNMIX_TEXT, 
     114    add_bool( MONO_CFG "downmix", VLC_FALSE, NULL, MONO_DOWNMIX_TEXT, 
    115115              MONO_DOWNMIX_LONGTEXT, VLC_FALSE ); 
    116     add_integer( MONO_CFG "mono-channel", -1, NULL, MONO_CHANNEL_TEXT, 
     116    add_integer( MONO_CFG "channel", -1, NULL, MONO_CHANNEL_TEXT, 
    117117        MONO_CHANNEL_LONGTEXT, VLC_FALSE ); 
    118118        change_integer_list( pi_pos_values, ppsz_pos_descriptions, 0 ); 
     
    380380        (p_filter->fmt_in.audio.i_rate != p_filter->fmt_out.audio.i_rate) && 
    381381        (p_filter->fmt_in.audio.i_format != AOUT_FMT_S16_NE) && 
    382         (p_filter->fmt_out.audio.i_format != AOUT_FMT_S16_NE) ) 
     382        (p_filter->fmt_out.audio.i_format != AOUT_FMT_S16_NE) && 
     383        (p_filter->fmt_in.audio.i_bitspersample != 
     384                                    p_filter->fmt_out.audio.i_bitspersample)) 
    383385    { 
    384386        msg_Err( p_this, "couldn't load mono filter" ); 
     
    394396    } 
    395397 
    396     var_Create( p_this, MONO_CFG "mono-downmix", 
     398    var_Create( p_this, MONO_CFG "downmix", 
    397399                VLC_VAR_BOOL | VLC_VAR_DOINHERIT ); 
    398     p_sys->b_downmix = var_GetBool( p_this, MONO_CFG "mono-downmix" ); 
    399  
    400     var_Create( p_this, MONO_CFG "mono-channel", 
     400    p_sys->b_downmix = var_GetBool( p_this, MONO_CFG "downmix" ); 
     401 
     402    var_Create( p_this, MONO_CFG "channel", 
    401403                VLC_VAR_INTEGER | VLC_VAR_DOINHERIT ); 
    402404    p_sys->i_channel_selected = 
    403             (unsigned int) var_GetInteger( p_this, MONO_CFG "mono-channel" ); 
     405            (unsigned int) var_GetInteger( p_this, MONO_CFG "channel" ); 
    404406 
    405407    if( p_sys->b_downmix ) 
    406408    { 
     409        msg_Dbg( p_this, "using stereo to mono downmix" ); 
    407410        p_filter->fmt_out.audio.i_physical_channels = AOUT_CHAN_CENTER; 
     411        p_filter->fmt_out.audio.i_channels = 1; 
    408412    } 
    409413    else 
    410414    { 
     415        msg_Dbg( p_this, "using pseudo mono" ); 
    411416        p_filter->fmt_out.audio.i_physical_channels = 
    412417                            (AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT); 
    413     } 
    414     p_filter->fmt_out.audio.i_channels = aout_FormatNbChannels( &(p_filter->fmt_out.audio) ); 
     418        p_filter->fmt_out.audio.i_channels = 2; 
     419    } 
    415420 
    416421    p_filter->fmt_out.audio.i_rate = p_filter->fmt_in.audio.i_rate; 
     
    454459    filter_sys_t *p_sys = p_filter->p_sys; 
    455460 
    456     var_Destroy( p_this, MONO_CFG "mono-channel" ); 
    457     var_Destroy( p_this, MONO_CFG "mono-downmix" ); 
     461    var_Destroy( p_this, MONO_CFG "channel" ); 
     462    var_Destroy( p_this, MONO_CFG "downmix" ); 
    458463    free( p_sys ); 
    459464} 
     
    517522    out_buf.i_nb_samples = p_out->i_samples; 
    518523 
     524    memset( p_out->p_buffer, 0, i_out_size ); 
    519525    if( p_filter->p_sys->b_downmix ) 
    520526    { 
    521         memset( out_buf.p_buffer, 0, i_out_size ); 
    522527        stereo2mono_downmix( (aout_instance_t *)p_filter, &aout_filter, 
    523528                             &in_buf, &out_buf ); 
     
    576581        i_overflow_size = p_sys->i_overflow_buffer_size; 
    577582 
    578         memset( p_out, 0, i_out_size ); 
    579583        if ( i_out_size > i_overflow_size ) 
    580584            memcpy( p_out, p_overflow, i_overflow_size );