Changeset 1287a64fd67f6117b0d8374290dcbcddb763239f

Timestamp:

05/09/08 17:00:24 (1 week ago)

Author:

Rémi Denis-Courmont <rem@videolan.org>

git-committer:

Rémi Denis-Courmont <rem@videolan.org> 1210345224 +0300

git-parent:

[cbc120de4ceb5c1ce66bb0b794f92246d7dec0b2]

git-author:

Rémi Denis-Courmont <rem@videolan.org> 1210279163 +0300

Message:

We also need to check the non "conf::" case. Oops.

Files:

• src/libvlc.c (modified) (1 diff)

src/libvlc.c

@@ -231 +231 @@
-        }
-    }
+    /* EXPLICIT HACK (this is the legacy API anyway):
+     * VLC_VariableSet is only used from the browser plugins, so we
+     *  can pretty much assume that the input is _not_ trusted. */
+    module_config_t *p_item;
+    p_item = config_FindConfig( VLC_OBJECT(p_libvlc), psz_var );
+    if( !p_item )
+        return VLC_ENOVAR;
+    if( !p_item->b_safe )
+        return VLC_EGENERIC;
-
-    i_ret = var_Set( p_libvlc, psz_var, value );