Changeset 10fcb9f9c3c73d13340c0bd4153fc4c9c87b7186

Show
Ignore:
Timestamp:
31/07/08 17:53:11 (4 months ago)
Author:
Rémi Duraffort <ivoire@videolan.org>
git-committer:
Rémi Duraffort <ivoire@videolan.org> 1217519591 +0200
git-parent:

[6b90843041ecdf3ae0bde9ce27a1d8327de56f48]

git-author:
Rémi Duraffort <ivoire@videolan.org> 1217519591 +0200
Message:

Access dvdread: use setenv instead of putenv to fix a memleak.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • modules/access/dvdread.c

    r9ecd185 r10fcb9f  
    223223#endif 
    224224 
    225     /* Override environment variable DVDCSS_METHOD with config option 
    226      * (FIXME: this creates a small memory leak) */ 
     225    /* Override environment variable DVDCSS_METHOD with config option */ 
    227226    psz_dvdcss_env = config_GetPsz( p_demux, "dvdread-css-method" ); 
    228227    if( psz_dvdcss_env && *psz_dvdcss_env ) 
    229     { 
    230         char *psz_env; 
    231  
    232         psz_env = malloc( strlen("DVDCSS_METHOD=") + 
    233                           strlen( psz_dvdcss_env ) + 1 ); 
    234         if( !psz_env ) 
    235         { 
    236             free( psz_dvdcss_env ); 
    237             return VLC_ENOMEM; 
    238         } 
    239  
    240         sprintf( psz_env, "%s%s", "DVDCSS_METHOD=", psz_dvdcss_env ); 
    241  
    242         putenv( psz_env ); 
    243     } 
     228        setenv( "DVDCSS_METHOD", psz_dvdcss_env, 1 ); 
    244229    free( psz_dvdcss_env ); 
    245230