Changeset 070e3454880e849f3ebca21d5f803cdd13351049

Timestamp:

31/05/08 22:51:19 (6 months ago)

Author:

Rémi Denis-Courmont <rdenis@simphalempin.com>

git-committer:

Rémi Denis-Courmont <rdenis@simphalempin.com> 1212267079 +0300

git-parent:

[90fd835fb4e43fcc2cb0b80d988b253843c4c548]

git-author:

Rémi Denis-Courmont <rdenis@simphalempin.com> 1212267079 +0300

Message:

Keep track of object held by threads

Files:

• src/misc/objects.c (modified) (6 diffs)

src/misc/objects.c

@@ -3 +3 @@
- *****************************************************************************
- * Copyright (C) 2004-2008 the VideoLAN team
- * $Id$
- *
- * Authors: Samuel Hocevar <sam@zoy.org>
@@ -82 +81 @@
-static void vlc_object_destroy( vlc_object_t *p_this );
-static void vlc_object_detach_unlocked (vlc_object_t *p_this);
+
+#ifndef NDEBUG
+static vlc_threadvar_t held_objects;
+typedef struct held_list_t
+{
+    struct held_list_t *next;
+    vlc_object_t *obj;
+} held_list_t;
+#endif
-
-/*****************************************************************************
@@ -143 +151 @@
-        p_priv->next = p_priv->prev = p_new;
-        vlc_mutex_init( &structure_lock );
+#ifndef NDEBUG
+        /* TODO: use the destruction callback to track ref leaks */
+        vlc_threadvar_create( &held_objects, NULL );
+#endif
-    }
-    else
@@ -372 +384 @@
-        /* We are the global object ... no need to lock. */
-        vlc_mutex_destroy( &structure_lock );
+#ifndef NDEBUG
+        vlc_threadvar_delete( &held_objects );
+#endif
-    }
-
@@ -779 +794 @@
-    internals->i_refcount++;
-    vlc_spin_unlock( &internals->ref_spin );
+#ifndef NDEBUG
+    /* Update the list of referenced objects */
+    /* Using TLS, so no need to lock */
+    held_list_t *newhead = malloc (sizeof (*newhead));
+    held_list_t *oldhead = vlc_threadvar_get (&held_objects);
+    newhead->next = oldhead;
+    newhead->obj = p_this;
+    vlc_threadvar_set (&held_objects, newhead);
+#endif
-}
-
@@ -789 +813 @@
-    vlc_object_internals_t *internals = vlc_internals( p_this );
-    bool b_should_destroy;
+
+#ifndef NDEBUG
+    /* Update the list of referenced objects */
+    /* Using TLS, so no need to lock */
+    for (held_list_t *hlcur = vlc_threadvar_get (&held_objects),
+                     *hlprev = NULL;
+         hlcur != NULL;
+         hlcur = hlcur->next)
+    {
+        if (hlcur->obj == p_this)
+        {
+            if (hlprev == NULL)
+                vlc_threadvar_set (&held_objects, hlcur->next);
+            else
+                hlprev->next = hlcur->next;
+            free (hlcur);
+            break;
+        }
+    }
+    /* TODO: what if releasing without references? */
+#endif
-
-    vlc_spin_lock( &internals->ref_spin );